Review Request 112118: Move KGlobalSettings to kde4support, stop compiling kdeui while at it
David Faure
faure at kde.org
Mon Aug 19 08:30:40 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112118/#review38099
-----------------------------------------------------------
Ship it!
staging/kde4support/autotests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112118/#comment28181>
The comment needs to be adjusted ;)
One such comment after each executable, then.
staging/kde4support/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112118/#comment28182>
I don't recognize this define, what does it do?
- David Faure
On Aug. 16, 2013, 4:15 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112118/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 4:15 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Moves KGlobalSettings to kde4support. It was the last class in kdeui so I removed the add_subdirectory(kdeui). This forced me to do some additional fixes that are also included in this patch, so that everything kept linking.
>
>
> Diffs
> -----
>
> kio/tests/krununittest.cpp a572458
> kio/tests/CMakeLists.txt df4348b
> kio/CMakeLists.txt 9bfe7a4
> kdeui/util/kglobalsettings.cpp 0f749f2
> kdeui/util/kglobalsettings.h 61264d2
> kdeui/tests/kglobalsettingstest.cpp
> kdeui/tests/kglobalsettingstest.h
> kdeui/tests/kglobalsettingsclient.cpp
> kdeui/tests/CMakeLists.txt 513b51a
> kdeui/CMakeLists.txt 7afa6bd
> CMakeLists.txt fb51ff4
> interfaces/kimproxy/library/CMakeLists.txt 0dcee60
> staging/kde4support/autotests/CMakeLists.txt 12fa24c
> staging/kde4support/src/CMakeLists.txt 9e9b1d1
>
> Diff: http://git.reviewboard.kde.org/r/112118/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/c4b2e073/attachment.html>
More information about the Kde-frameworks-devel
mailing list