<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112118/">http://git.reviewboard.kde.org/r/112118/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112118/diff/1/?file=181511#file181511line69" style="color: black; font-weight: bold; text-decoration: underline;">staging/kde4support/autotests/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># Helper for klockfiletest</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># Helper for klockfiletest</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The comment needs to be adjusted ;)
One such comment after each executable, then.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112118/diff/1/?file=181512#file181512line29" style="color: black; font-weight: bold; text-decoration: underline;">staging/kde4support/src/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">add_definitions</span><span class="p">(</span><span class="s">-DDISABLE_DEPRECATION</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't recognize this define, what does it do?</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On August 16th, 2013, 4:15 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2013, 4:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moves KGlobalSettings to kde4support. It was the last class in kdeui so I removed the add_subdirectory(kdeui). This forced me to do some additional fixes that are also included in this patch, so that everything kept linking.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/tests/krununittest.cpp <span style="color: grey">(a572458)</span></li>
<li>kio/tests/CMakeLists.txt <span style="color: grey">(df4348b)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(9bfe7a4)</span></li>
<li>kdeui/util/kglobalsettings.cpp <span style="color: grey">(0f749f2)</span></li>
<li>kdeui/util/kglobalsettings.h <span style="color: grey">(61264d2)</span></li>
<li>kdeui/tests/kglobalsettingstest.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/kglobalsettingstest.h <span style="color: grey">()</span></li>
<li>kdeui/tests/kglobalsettingsclient.cpp <span style="color: grey">()</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(513b51a)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(7afa6bd)</span></li>
<li>CMakeLists.txt <span style="color: grey">(fb51ff4)</span></li>
<li>interfaces/kimproxy/library/CMakeLists.txt <span style="color: grey">(0dcee60)</span></li>
<li>staging/kde4support/autotests/CMakeLists.txt <span style="color: grey">(12fa24c)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(9e9b1d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112118/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>