Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111636/#review38098
-----------------------------------------------------------



staging/kio/src/core/authinfo.cpp
<http://git.reviewboard.kde.org/r/111636/#comment28178>

    The boolean OR operator is ||, not |.
    | is bitwise OR.
    



staging/kio/src/core/authinfo.cpp
<http://git.reviewboard.kde.org/r/111636/#comment28179>

    Missing
      && i+1 < stringList.size()
    
    to ensure the stringList.at(i+1) call on the next line doesn't go out of bounds.



staging/kio/src/core/authinfo.cpp
<http://git.reviewboard.kde.org/r/111636/#comment28180>

    Where is "buf" used in this method?
    
    It seems to be used before this += operation (the extract() for "macdef" is before the loop), so this seems rather useless?
    
    Ah, given the comment in the caller of getMacdefPart, I suppose the last line should say append(buf), not append(line)?


- David Faure


On Aug. 18, 2013, 10 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111636/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2013, 10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port away from kde_file.h in AuthInfo (KIO)
> 
> 
> Diffs
> -----
> 
>   staging/kio/src/core/authinfo.h d6415b2f2e9ccec7c3e046f569fb44dbbc879d6b 
>   staging/kio/src/core/authinfo.cpp 65ebacf84e989f19f1b896c596a6b24185c67447 
> 
> Diff: http://git.reviewboard.kde.org/r/111636/diff/
> 
> 
> Testing
> -------
> 
> It builds. I have tested the part of the code not related to loginMap with a little program and .netrc sample files, to check whether it correctly parses the information.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130819/13b3cecc/attachment.html>