Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111636/
-----------------------------------------------------------

(Updated Aug. 18, 2013, 10 p.m.)


Review request for KDE Frameworks.


Changes
-------

- Fix issues told by Kevin and D. Faure.

- Move some methods to NetRCPrivate to keep binary compatibility in the future (I thought about moving also parse(), but I didn't).

- Fix a bug that made it compulsory to have both .netrc and kionetrc, otherwise lookup() returned false.

- Tested with kionetrctest and a .netrc sample file (with chmod 600):

$ ./kionetrctest ftp://host1.millenia.com

returns the info and the macros of that host in the file.


Description (updated)
-------

Port away from kde_file.h in AuthInfo (KIO)


Diffs (updated)
-----

  staging/kio/src/core/authinfo.h d6415b2f2e9ccec7c3e046f569fb44dbbc879d6b 
  staging/kio/src/core/authinfo.cpp 65ebacf84e989f19f1b896c596a6b24185c67447 

Diff: http://git.reviewboard.kde.org/r/111636/diff/


Testing
-------

It builds. I have tested the part of the code not related to loginMap with a little program and .netrc sample files, to check whether it correctly parses the information.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130818/5d9c35b1/attachment.html>