Review Request 112064: Port S_IS*(x) macros to their qplatformdefs equivalents

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112064/#review37944
-----------------------------------------------------------

Ship it!


Q_OS_UNIX is better, because the "ifndef S_ISSOCK" could break due to a missing #include - i.e. it would silently disable the check (on some unix system where it should actually happen) just because the #include that defines S_ISSOCK is missing for some reason.

- David Faure


On Aug. 16, 2013, 10:31 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112064/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2013, 10:31 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port S_IS*(x) macros to their qplatformdefs equivalents because they do not exist on Windows:
> 
> S_ISLNK(x) => (x & QT_STAT_LNK)
> S_ISREG(x) => (x & QT_STAT_REG)
> S_ISDIR(x) => (x & QT_STAT_DIR)
> 
> Some of those macros do not have equivalents though. Some are used in files which do not matter for Windows, but not all of them:
> 
> kdesu/client.cpp:
> - S_ISSOCK
> 
> kioslave/file/file_unix.cpp:
> - S_ISFIFO
> - S_ISSOCK
> 
> kpty/kgrantpty.c:
> - S_ISCHR
> 
> staging/kio/src/core/kfileitem.cpp:
> - S_ISSOCK
> - S_ISCHR
> - S_ISBLK
> - S_ISFIFO
> 
> tier1/solid/src/solid/backends/shared/udevqtclient.cpp:
> - S_ISBLK
> - S_ISCHR
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_part.cpp d944a29 
>   kio/kfile/kpropertiesdialog.cpp 995e962 
>   kio/kio/krun.cpp db727cc 
>   kio/tests/fileundomanagertest.cpp c8cde0c 
>   kio/tests/kioslavetest.cpp 8a894e1 
>   kio/tests/kiotesthelper.h b0082fe 
>   kioslave/file/file.cpp 6329fab 
>   kioslave/file/file_unix.cpp 1eb2279 
>   staging/kio/src/core/kfileitem.cpp f8a4ac1 
>   staging/kio/src/core/udsentry.cpp df52d97 
>   staging/kio/src/widgets/kurlcompletion.cpp 2378086 
>   tier1/karchive/src/k7zip.cpp 2957f30 
>   tier1/karchive/src/kzip.cpp 1390b4a 
>   tier1/kcoreaddons/src/io/kdirwatch.cpp 6590ee2 
> 
> Diff: http://git.reviewboard.kde.org/r/112064/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130816/008684b4/attachment.html>