<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112064/">http://git.reviewboard.kde.org/r/112064/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Q_OS_UNIX is better, because the "ifndef S_ISSOCK" could break due to a missing #include - i.e. it would silently disable the check (on some unix system where it should actually happen) just because the #include that defines S_ISSOCK is missing for some reason.</pre>
<br />
<p>- David</p>
<br />
<p>On August 16th, 2013, 10:31 a.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2013, 10:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port S_IS*(x) macros to their qplatformdefs equivalents because they do not exist on Windows:
S_ISLNK(x) => (x & QT_STAT_LNK)
S_ISREG(x) => (x & QT_STAT_REG)
S_ISDIR(x) => (x & QT_STAT_DIR)
Some of those macros do not have equivalents though. Some are used in files which do not matter for Windows, but not all of them:
kdesu/client.cpp:
- S_ISSOCK
kioslave/file/file_unix.cpp:
- S_ISFIFO
- S_ISSOCK
kpty/kgrantpty.c:
- S_ISCHR
staging/kio/src/core/kfileitem.cpp:
- S_ISSOCK
- S_ISCHR
- S_ISBLK
- S_ISFIFO
tier1/solid/src/solid/backends/shared/udevqtclient.cpp:
- S_ISBLK
- S_ISCHR
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/khtml_part.cpp <span style="color: grey">(d944a29)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(995e962)</span></li>
<li>kio/kio/krun.cpp <span style="color: grey">(db727cc)</span></li>
<li>kio/tests/fileundomanagertest.cpp <span style="color: grey">(c8cde0c)</span></li>
<li>kio/tests/kioslavetest.cpp <span style="color: grey">(8a894e1)</span></li>
<li>kio/tests/kiotesthelper.h <span style="color: grey">(b0082fe)</span></li>
<li>kioslave/file/file.cpp <span style="color: grey">(6329fab)</span></li>
<li>kioslave/file/file_unix.cpp <span style="color: grey">(1eb2279)</span></li>
<li>staging/kio/src/core/kfileitem.cpp <span style="color: grey">(f8a4ac1)</span></li>
<li>staging/kio/src/core/udsentry.cpp <span style="color: grey">(df52d97)</span></li>
<li>staging/kio/src/widgets/kurlcompletion.cpp <span style="color: grey">(2378086)</span></li>
<li>tier1/karchive/src/k7zip.cpp <span style="color: grey">(2957f30)</span></li>
<li>tier1/karchive/src/kzip.cpp <span style="color: grey">(1390b4a)</span></li>
<li>tier1/kcoreaddons/src/io/kdirwatch.cpp <span style="color: grey">(6590ee2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112064/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>