Review Request 112038: Look for LibAttica where needed

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 2:12 p.m.)


Review request for KDE Frameworks and Stephen Kelly.


Changes
-------

Attica now exports its includes dir (commit 4fbc163)


Description
-------

The issue was uncovered by https://git.reviewboard.kde.org/r/111937. LibAttica::attica is in the LINK_PUBLIC entries for XmlGui and in the IMPORTED_LINK_DEPENDENT_LIBRARIES for KDE4__knewstuff3 but none of these is looking for Attica.

With this patch, both KDELibs4Config.cmake and XmlGuiConfig.cmake look for Attica.


Diffs (updated)
-----

  KDELibs4Config.cmake bd91efb 
  staging/xmlgui/XmlGuiConfig.cmake.in 08da417 
  staging/xmlgui/src/CMakeLists.txt 46dc74a 

Diff: http://git.reviewboard.kde.org/r/112038/diff/


Testing
-------

Konsole build with https://git.reviewboard.kde.org/r/111937 without the 'find_package(LibAttica NO_MODULE) line'.


Thanks,

Christophe Giboudeaux

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/b0e1a647/attachment.html>