Review Request 112038: Look for LibAttica where needed

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112038/#review37683
-----------------------------------------------------------


Finding dependencies in config files is a generally/generically unsolved issue in frameworks currently, but a patch like this makes sense to until there's a generic solution.


KDELibs4Config.cmake
<http://git.reviewboard.kde.org/r/112038/#comment27845>

    This shouldn't be needed. The AtticaConfig.cmake should set appropriate INTERFACE_INCLUDE_DIRECTORIES instead.



staging/xmlgui/XmlGuiConfig.cmake.in
<http://git.reviewboard.kde.org/r/112038/#comment27846>

    Not needed when Attica sets INTERFACE_INCLUDE_DIRECTORIES.


- Stephen Kelly


On Aug. 12, 2013, 8:48 p.m., Christophe Giboudeaux wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112038/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 8:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Description
> -------
> 
> The issue was uncovered by https://git.reviewboard.kde.org/r/111937. LibAttica::attica is in the LINK_PUBLIC entries for XmlGui and in the IMPORTED_LINK_DEPENDENT_LIBRARIES for KDE4__knewstuff3 but none of these is looking for Attica.
> 
> With this patch, both KDELibs4Config.cmake and XmlGuiConfig.cmake look for Attica.
> 
> 
> Diffs
> -----
> 
>   KDELibs4Config.cmake bd91efb 
>   staging/xmlgui/XmlGuiConfig.cmake.in 08da417 
>   staging/xmlgui/src/CMakeLists.txt 46dc74a 
> 
> Diff: http://git.reviewboard.kde.org/r/112038/diff/
> 
> 
> Testing
> -------
> 
> Konsole build with https://git.reviewboard.kde.org/r/111937 without the 'find_package(LibAttica NO_MODULE) line'.
> 
> 
> Thanks,
> 
> Christophe Giboudeaux
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130813/8ecefa55/attachment.html>