Review Request 111981: Mark strigi as optional dependancy, move it's check to kde4support and remove FindStrigi.cmake file

[Kevin Ottens]

> On Aug. 12, 2013, 9:38 a.m., Kevin Ottens wrote:
> > Hm, doesn't just removing FindStrigi.cmake make strigi completely impossible to find now? I see that extra-cmake-module still has FindStrigi in attic too. I find the patch overall ok except for that part... maybe that's just me missing something though.
> 
> Hrvoje Senjan wrote:
>     Strigi has StrigiConfig.cmake which should be sufficient.

Ah indeed, I missed that change there.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111981/#review37567
-----------------------------------------------------------


On Aug. 9, 2013, 9:32 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111981/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 9:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Follow up to r111897. As said in summary - strigi is not *required* anymore.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3e8e639 
>   cmake/modules-tests/RunAllModuleTests.cmake 1ccce7d 
>   cmake/modules-tests/Strigi/CMakeLists.txt bbe1e23 
>   cmake/modules/CMakeLists.txt 06f5c67 
>   cmake/modules/FindStrigi.cmake bb87b0d 
>   staging/kde4support/CMakeLists.txt c0e81ad 
>   staging/kde4support/src/CMakeLists.txt bebce74 
> 
> Diff: http://git.reviewboard.kde.org/r/111981/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine without strigi.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130812/86965883/attachment.html>