<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111981/">http://git.reviewboard.kde.org/r/111981/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 12th, 2013, 9:38 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, doesn't just removing FindStrigi.cmake make strigi completely impossible to find now? I see that extra-cmake-module still has FindStrigi in attic too. I find the patch overall ok except for that part... maybe that's just me missing something though.</pre>
</blockquote>
<p>On August 12th, 2013, 12:05 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Strigi has StrigiConfig.cmake which should be sufficient.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah indeed, I missed that change there.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 9th, 2013, 9:32 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2013, 9:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Follow up to r111897. As said in summary - strigi is not *required* anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles fine without strigi.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3e8e639)</span></li>
<li>cmake/modules-tests/RunAllModuleTests.cmake <span style="color: grey">(1ccce7d)</span></li>
<li>cmake/modules-tests/Strigi/CMakeLists.txt <span style="color: grey">(bbe1e23)</span></li>
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(06f5c67)</span></li>
<li>cmake/modules/FindStrigi.cmake <span style="color: grey">(bb87b0d)</span></li>
<li>staging/kde4support/CMakeLists.txt <span style="color: grey">(c0e81ad)</span></li>
<li>staging/kde4support/src/CMakeLists.txt <span style="color: grey">(bebce74)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111981/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>