Review Request 111916: Port khtml_part away from kde_file.h

[Vishesh Handa]

> On Aug. 12, 2013, 9:40 a.m., David Faure wrote:
> > khtml/khtml_part.cpp, line 3580
> > <http://git.reviewboard.kde.org/r/111916/diff/2/?file=178128#file178128line3580>
> >
> >     Is this variable still used?

Yes. A couple of lines below -

      int n = readlink ( path.toLocal8Bit().data(), buff_two, 1022);

I can replace it over here if you want?


> On Aug. 12, 2013, 9:40 a.m., David Faure wrote:
> > khtml/khtml_part.cpp, line 3585
> > <http://git.reviewboard.kde.org/r/111916/diff/2/?file=178128#file178128line3585>
> >
> >     That's not what lstat does....
> >     
> >     The case where stat() fails and lstat() succeeds is the case of a broken symlink.
> >     
> >     In that case, QFileInfo::exists() returns false. I guess all we can do then is skip this second check, and use if (info.isSymlink()) below, without ok&& in front. I.e. always go into the symlink code, whether the symlink is valid or broken.

It's slightly confusing that a file can not exist, but can still be a system link.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review37565
-----------------------------------------------------------


On Aug. 12, 2013, 9:35 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111916/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 9:35 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
>  Port khtml_part away from kde_file.h
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_part.cpp d944a29 
> 
> Diff: http://git.reviewboard.kde.org/r/111916/diff/
> 
> 
> Testing
> -------
> 
> Compiles. The tests seem to segfault with and without this patch. I'll try to diagnose it.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130812/64dc803e/attachment.html>