Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111945/#review37416
-----------------------------------------------------------



tier1/kconfig/src/gui/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111945/#comment27687>

    By the same logic, 
    
     target_link_libraries(test1 KConfigCore KConfigGui)
    
    can be simplified to
     
     target_link_libraries(test1 KConfigGui)
    
    Having smaller lists makes it easier to see something that should not be there, because, as you say, we can't remove excess items for BC reasons. Of course, removing something which is redundant (like Qt5::Core in this case) is ok BC-wise.


- Stephen Kelly


On Aug. 8, 2013, 4:09 p.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111945/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 4:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Task from kdelibs cleanup.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/src/core/CMakeLists.txt 398a1d7 
>   tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt b04b867 
>   tier1/kconfig/autotests/CMakeLists.txt 751396f 
>   tier1/kconfig/src/gui/CMakeLists.txt 91f013b 
>   tier1/kdbusaddons/autotests/CMakeLists.txt bf03734 
>   tier1/kdbusaddons/src/CMakeLists.txt 25d1f60 
>   tier1/kdbusaddons/tests/CMakeLists.txt 57e6d4f 
>   tier1/kidletime/src/CMakeLists.txt d709b2b 
>   tier1/kjs/src/kjs/CMakeLists.txt ebbb820 
>   tier1/kjs/src/kjs/api/CMakeLists.txt 4d5c5d6 
>   tier1/kplotting/autotests/CMakeLists.txt afebdee 
>   tier1/kplotting/src/CMakeLists.txt 7ce75bd 
>   tier1/kwidgetsaddons/autotests/CMakeLists.txt 870e16e 
>   tier1/kwidgetsaddons/src/CMakeLists.txt c64302a 
>   tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
>   tier1/sonnet/autotests/CMakeLists.txt 88574ff 
>   tier1/sonnet/src/plugins/aspell/CMakeLists.txt 70f06d1 
>   tier1/sonnet/src/plugins/enchant/CMakeLists.txt 2319be8 
>   tier1/sonnet/src/plugins/hspell/CMakeLists.txt c7cafc5 
>   tier1/sonnet/src/plugins/hunspell/CMakeLists.txt a0e2d9b 
>   tier1/sonnet/src/ui/CMakeLists.txt 723d8f3 
>   tier1/sonnet/src/unicode/CMakeLists.txt 6b5d27d 
>   tier1/sonnet/tests/CMakeLists.txt 6e0e450 
>   tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c 
> 
> Diff: http://git.reviewboard.kde.org/r/111945/diff/
> 
> 
> Testing
> -------
> 
> It builds and tests looks OK.
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130809/6e7518bf/attachment.html>