Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

[Wojciech Kapuscinski]

> On Aug. 9, 2013, 11:27 a.m., Kevin Ottens wrote:
> > tier1/kconfig/src/gui/CMakeLists.txt, line 15
> > <http://git.reviewboard.kde.org/r/111945/diff/1/?file=177388#file177388line15>
> >
> >     The LINK_PUBLIC is ok here, but is the Qt5::Core necessary? Doesn't it get picked up by transitivity with KConfigCore?
> >     
> >     Just wondering, I admit I'm unsure.

Qt5::Core isn't necessary. 
There was discussion on k-f-d but without clear statement what is better (add Qt5::Core or not) so I looked into all public headers and if there were classes from Qt5::Core I added to PUBLIC_LINK.

I'm not unsure if this solution is OK. Tier1 is simple but in higher tiers this could be more verbose (personally I believe code is for human, for computer it doesn't matter :) ).
Witch way I should go? :)

(NOTE: changing LINK_PUBLIC in future is BIC)


- Wojciech


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111945/#review37406
-----------------------------------------------------------


On Aug. 8, 2013, 4:09 p.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111945/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 4:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Task from kdelibs cleanup.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/src/core/CMakeLists.txt 398a1d7 
>   tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt b04b867 
>   tier1/kconfig/autotests/CMakeLists.txt 751396f 
>   tier1/kconfig/src/gui/CMakeLists.txt 91f013b 
>   tier1/kdbusaddons/autotests/CMakeLists.txt bf03734 
>   tier1/kdbusaddons/src/CMakeLists.txt 25d1f60 
>   tier1/kdbusaddons/tests/CMakeLists.txt 57e6d4f 
>   tier1/kidletime/src/CMakeLists.txt d709b2b 
>   tier1/kjs/src/kjs/CMakeLists.txt ebbb820 
>   tier1/kjs/src/kjs/api/CMakeLists.txt 4d5c5d6 
>   tier1/kplotting/autotests/CMakeLists.txt afebdee 
>   tier1/kplotting/src/CMakeLists.txt 7ce75bd 
>   tier1/kwidgetsaddons/autotests/CMakeLists.txt 870e16e 
>   tier1/kwidgetsaddons/src/CMakeLists.txt c64302a 
>   tier1/kwindowsystem/src/CMakeLists.txt fe0f920 
>   tier1/sonnet/autotests/CMakeLists.txt 88574ff 
>   tier1/sonnet/src/plugins/aspell/CMakeLists.txt 70f06d1 
>   tier1/sonnet/src/plugins/enchant/CMakeLists.txt 2319be8 
>   tier1/sonnet/src/plugins/hspell/CMakeLists.txt c7cafc5 
>   tier1/sonnet/src/plugins/hunspell/CMakeLists.txt a0e2d9b 
>   tier1/sonnet/src/ui/CMakeLists.txt 723d8f3 
>   tier1/sonnet/src/unicode/CMakeLists.txt 6b5d27d 
>   tier1/sonnet/tests/CMakeLists.txt 6e0e450 
>   tier1/threadweaver/src/WeaverGui/CMakeLists.txt f92577c 
> 
> Diff: http://git.reviewboard.kde.org/r/111945/diff/
> 
> 
> Testing
> -------
> 
> It builds and tests looks OK.
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130809/e044c55a/attachment.html>