Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls
Kevin Ottens
ervin at kde.org
Fri Aug 9 11:34:28 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111943/#review37407
-----------------------------------------------------------
To avoid overlapping on the kde_file.h porting work, don't port KDE_ and KDE:: code, only straight POSIX calls.
khtml/khtml_part.cpp
<http://git.reviewboard.kde.org/r/111943/#comment27679>
Hm isn't it one of those cases of overlap with removing kde_file.h ?
Yep, this file is covered by review 111916.
kioslave/ftp/ftp.cpp
<http://git.reviewboard.kde.org/r/111943/#comment27680>
Yet another case of overlap with kde_file.h
This time covered by review 111911
- Kevin Ottens
On Aug. 8, 2013, 4:16 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111943/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 4:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> This patch ports some libc calls to use qplatformdefs.h. It ports all variants of stat() and all calls to fopen(). I skipped .c files as well as Windows and Mac-OS specific code.
>
>
> Diffs
> -----
>
> kdesu/client.cpp c228ab9
> khtml/html/ksslkeygen.cpp 3726353
> khtml/khtml_part.cpp d944a29
> kio/kssl/ksslcertificate.cpp fcd097f
> kioslave/ftp/ftp.cpp a0da54b
> kioslave/http/kcookiejar/tests/kcookiejartest.cpp db5315d
> kpty/kpty.cpp 059b8f3
> staging/kio/autotests/kmountpointtest.cpp d858b8a
> staging/kio/src/core/copyjob.cpp 18b7dad
> tier1/kcoreaddons/tests/kdirwatchtest_gui.cpp d9f95f7
> tier1/solid/src/solid/backends/shared/udevqtclient.cpp 4bf650c
>
> Diff: http://git.reviewboard.kde.org/r/111943/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130809/9ecbaa4d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list