<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111943/">http://git.reviewboard.kde.org/r/111943/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To avoid overlapping on the kde_file.h porting work, don't port KDE_ and KDE:: code, only straight POSIX calls.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111943/diff/2/?file=177412#file177412line3581" style="color: black; font-weight: bold; text-decoration: underline;">khtml/khtml_part.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KHTMLPart::overURL( const QString &url, const QString &target, bool /*shiftPressed*/ )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">3580</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> KDE_struct_stat buff;</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3581</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> QT_STATBUF buff;</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm isn't it one of those cases of overlap with removing kde_file.h ?
Yep, this file is covered by review 111916.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111943/diff/2/?file=177414#file177414line2391" style="color: black; font-weight: bold; text-decoration: underline;">kioslave/ftp/ftp.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Ftp::copy( const QUrl &src, const QUrl &dest, int permissions, KIO::JobFlags flags )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2390</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">bSrcExists</span> <span class="o">=</span> <span class="p">(</span><span class="n"><span class="hl">KDE</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">stat</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n">sCopyFile</span><span class="p">,</span> <span class="o">&</span><span class="n">buff</span> <span class="p">)</span> <span class="o">!=</span> <span class="o">-</span><span class="mi">1</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2391</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">bSrcExists</span> <span class="o">=</span> <span class="p">(</span><span class="n"><span class="hl">QT_STAT</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="n"><span class="hl">QFile</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">encodeName</span></span><span class="p"><span class="hl">(</span></span><span class="n">sCopyFile</span><span class="p"><span class="hl">).</span></span><span class="n"><span class="hl">constData</span></span><span class="p"><span class="hl">()</span>,</span> <span class="o">&</span><span class="n">buff</span> <span class="p">)</span> <span class="o">!=</span> <span class="o">-</span><span class="mi">1</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yet another case of overlap with kde_file.h
This time covered by review 111911</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On August 8th, 2013, 4:16 p.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2013, 4:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports some libc calls to use qplatformdefs.h. It ports all variants of stat() and all calls to fopen(). I skipped .c files as well as Windows and Mac-OS specific code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdesu/client.cpp <span style="color: grey">(c228ab9)</span></li>
<li>khtml/html/ksslkeygen.cpp <span style="color: grey">(3726353)</span></li>
<li>khtml/khtml_part.cpp <span style="color: grey">(d944a29)</span></li>
<li>kio/kssl/ksslcertificate.cpp <span style="color: grey">(fcd097f)</span></li>
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(a0da54b)</span></li>
<li>kioslave/http/kcookiejar/tests/kcookiejartest.cpp <span style="color: grey">(db5315d)</span></li>
<li>kpty/kpty.cpp <span style="color: grey">(059b8f3)</span></li>
<li>staging/kio/autotests/kmountpointtest.cpp <span style="color: grey">(d858b8a)</span></li>
<li>staging/kio/src/core/copyjob.cpp <span style="color: grey">(18b7dad)</span></li>
<li>tier1/kcoreaddons/tests/kdirwatchtest_gui.cpp <span style="color: grey">(d9f95f7)</span></li>
<li>tier1/solid/src/solid/backends/shared/udevqtclient.cpp <span style="color: grey">(4bf650c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111943/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>