kdelibs-frameworks i386 build failiures

Rohan Garg rohan at kde.org
Thu Aug 8 10:27:55 UTC 2013


> kdecore/CMakeLists.txt says
>   target_compile_definitions(kdecore PUBLIC -D_FILE_OFFSET_BITS=64)
> Maybe you want to move that to kioslave/file? It's the only user of off_t.
>

Moving it to kioslave/file/CMakeLists.txt did indeed fix this issue.
Should I go ahead and commit the patch [1] ? Maybe even drop the TODO
comment in there since it seems like kde_file.h is going away?

[1] http://paste.ubuntu.com/5962137/


More information about the Kde-frameworks-devel mailing list