kdelibs-frameworks i386 build failiures

[David Faure]

On Thursday 08 August 2013 10:39:25 Rohan Garg wrote:
> Hi
> It seems like the frameworks branch of kdelibs is currently failing on
> i386 with the following failure :
> 
> /build/buildd/project-neon5-kdelibs-0.0+git20130808+r96198~736598e+neon11~sa
> ucy1/kioslave/file/file_unix.cpp: In member function 'virtual void
> FileProtocol::rename(const QUrl&, const QUrl&, KIO::JobFlags)':
> /build/buildd/project-neon5-kdelibs-0.0+git20130808+r96198~736598e+neon11~sa
> ucy1/kioslave/file/file_unix.cpp:419:61: error: size of array
> 'off_t_should_be_64_bits' is negative
>      char off_t_should_be_64_bits[sizeof(off_t) >= 8 ? 1 : -1]; (void)
> off_t_should_be_64_bits;
>                                                              ^
> make[3]: *** [kioslave/file/CMakeFiles/kio_file.dir/file_unix.cpp.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> 
> I've been told that the right fix is to define _FILE_OFFSET_BITS=64 ,
> except I can't see any recent changes that might have caused this
> issue ( or maybe I'm missing something obvious ). Could someone who
> knows more about this look into it? 

Maybe the removal of kde_file.h (ad923024e4fcb)

Neither build.kde.org nor our development machines caught this, apparently 
because it's all 64 bit machines.

kdecore/CMakeLists.txt says 
  target_compile_definitions(kdecore PUBLIC -D_FILE_OFFSET_BITS=64)
Maybe you want to move that to kioslave/file? It's the only user of off_t.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5