Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

[Jon Severinsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107038/
-----------------------------------------------------------

(Updated Oct. 26, 2012, 10:59 a.m.)


Review request for KDE Frameworks.


Changes
-------

Updated patch with unit tests.

The unit test implementation became a bit uggly, as there was no way to reset KSystemTimeZonesPrivate, so I had to create one...


Description
-------

If the time zone file for the kconfig configured local time zone does not
exist in the kconfig configured zoneinfo directory, setLocalZone() would
set a time zone where isValid() returns true, but all time zone information
is garbage. This commit changes setLocalZone() to instead set the utc fallback
time zone as the local time zone.


Diffs (updated)
-----

  kdecore/date/ksystemtimezone.cpp aaa10fd 
  kdecore/tests/ktimezonestest.h 16ba1d0 
  kdecore/tests/ktimezonestest.cpp 8ea48a4 

Diff: http://git.reviewboard.kde.org/r/107038/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121026/6c68fef5/attachment.html>