Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107038/#review20896
-----------------------------------------------------------


Ah ok, setting UTC is probably better than making the whole thing invalid and un-debuggable, indeed.

All that's missing is a unit test :-)

- David Faure


On Oct. 25, 2012, 2:49 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107038/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 2:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> If the time zone file for the kconfig configured local time zone does not
> exist in the kconfig configured zoneinfo directory, setLocalZone() would
> set a time zone where isValid() returns true, but all time zone information
> is garbage. This commit changes setLocalZone() to instead set the utc fallback
> time zone as the local time zone.
> 
> 
> Diffs
> -----
> 
>   kdecore/date/ksystemtimezone.cpp aaa10fd 
> 
> Diff: http://git.reviewboard.kde.org/r/107038/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121025/8af58e35/attachment.html>