Review Request: Fix KMimeTypeTest::testAllMimeTypes

David Faure faure at kde.org
Tue Oct 23 10:05:20 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107006/#review20729
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Oct. 23, 2012, 9:23 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107006/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 9:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Don't use QEXPECT_FAIL for mimetypes with possible conflicting defenitions.
> That will cause the test to fail on clean systems without the conflicting
> defenition in XDG_DATA_DIRS. Instead just skip the QCOMPARE for those mime
> types.
> 
> 
> Diffs
> -----
> 
>   staging/kde4support/autotests/kmimetypetest.cpp 55f3518 
> 
> Diff: http://git.reviewboard.kde.org/r/107006/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121023/1bcb7640/attachment.html>


More information about the Kde-frameworks-devel mailing list