Review Request: Fix KMimeTypeTest::testAllMimeTypes

Jon Severinsson jon at severinsson.net
Tue Oct 23 09:23:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107006/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

Don't use QEXPECT_FAIL for mimetypes with possible conflicting defenitions.
That will cause the test to fail on clean systems without the conflicting
defenition in XDG_DATA_DIRS. Instead just skip the QCOMPARE for those mime
types.


Diffs
-----

  staging/kde4support/autotests/kmimetypetest.cpp 55f3518 

Diff: http://git.reviewboard.kde.org/r/107006/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121023/b0b774a4/attachment.html>


More information about the Kde-frameworks-devel mailing list