Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

[Jon Severinsson]

> On Oct. 31, 2012, 4:58 p.m., David Faure wrote:
> > The circular dependency (due to libinqt5 being in kdelibs currently) will make building a bit harder though. Shouldn't ECM be fixed NOT to require libinqt5?
> 
> Jon Severinsson wrote:
>     There is no circular dependency, as libinqt5 does not depend on Phonon. The repository layout may make it look like a circular dependency, but that is just an illusion. In reality, Phonon is just another tier 1 framework, and just like all other tier 1 frameworks it should depend on libinqt5.
>     
>     To enable building all frameworks in one go, we could add phonon five as a git submodule in the frameworks branch, but personally I think that is overkill.
> 
> David Faure wrote:
>     Yes I know, I mean at the git module level, in the current situation.
>     It would break "kdesrc-build phonon kdelibs", which currently works, that's all I mean.
>     
>     For now, how about this fix/hack?
>     
>     --- a/find-modules/FindQt5Transitional.cmake
>     +++ b/find-modules/FindQt5Transitional.cmake
>     @@ -59,7 +59,7 @@ else()
>      
>        # if we are not called from a build of a complete kdelibs, which contains libinqt5,
>        # additionally search for libinqt5:
>     -  if(NOT kdelibs_SOURCE_DIR AND NOT inqt5_SOURCE_DIR AND NOT TARGET inqt5)
>     +  if(NOT phonon_SOURCE_DIR AND NOT kdelibs_SOURCE_DIR AND NOT inqt5_SOURCE_DIR AND NOT TARGET inqt5)
>          find_package(inqt5 REQUIRED NO_MODULE)
>          include_directories(${inqt5_INCLUDE_DIR})
>        endif()
>     
>     Anyway, this means "ship it", and I'll fix FindQt5Transitional when it starts to annoy me :-)

That would work for now, but if/when phonon five is updated further, it might actually need libinqt5. But I guess we will simply have to cross that bridge when we come to it.


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106970/#review21251
-----------------------------------------------------------


On Oct. 20, 2012, 6:56 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106970/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 6:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> This patch is based on my "Phonon five merge and cleanup" patch, and is a step towards building Phonon five on Qt5.
> 
> On Qt4 the build system will now insist on "libinqt5" being installed,
> which is located in the kdelibs repository in the frameworks branch.
> There is, however, no dependancy on the actual KDE Frameworks 5, and
> libinqt5 can be build and installed standalone.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 20220a3 
>   demos/metadatareader/CMakeLists.txt fe6eb60 
>   demos/phota/CMakeLists.txt 2306c7e 
>   demos/simplecapture/CMakeLists.txt 4a2e1b0 
>   demos/simpleplayer/CMakeLists.txt 6824142 
> 
> Diff: http://git.reviewboard.kde.org/r/106970/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121101/3a56482c/attachment.html>