<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106970/">http://git.reviewboard.kde.org/r/106970/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 31st, 2012, 4:58 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The circular dependency (due to libinqt5 being in kdelibs currently) will make building a bit harder though. Shouldn't ECM be fixed NOT to require libinqt5?</pre>
</blockquote>
<p>On October 31st, 2012, 8:22 p.m., <b>Jon Severinsson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no circular dependency, as libinqt5 does not depend on Phonon. The repository layout may make it look like a circular dependency, but that is just an illusion. In reality, Phonon is just another tier 1 framework, and just like all other tier 1 frameworks it should depend on libinqt5.
To enable building all frameworks in one go, we could add phonon five as a git submodule in the frameworks branch, but personally I think that is overkill.</pre>
</blockquote>
<p>On October 31st, 2012, 8:31 p.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes I know, I mean at the git module level, in the current situation.
It would break "kdesrc-build phonon kdelibs", which currently works, that's all I mean.
For now, how about this fix/hack?
--- a/find-modules/FindQt5Transitional.cmake
+++ b/find-modules/FindQt5Transitional.cmake
@@ -59,7 +59,7 @@ else()
# if we are not called from a build of a complete kdelibs, which contains libinqt5,
# additionally search for libinqt5:
- if(NOT kdelibs_SOURCE_DIR AND NOT inqt5_SOURCE_DIR AND NOT TARGET inqt5)
+ if(NOT phonon_SOURCE_DIR AND NOT kdelibs_SOURCE_DIR AND NOT inqt5_SOURCE_DIR AND NOT TARGET inqt5)
find_package(inqt5 REQUIRED NO_MODULE)
include_directories(${inqt5_INCLUDE_DIR})
endif()
Anyway, this means "ship it", and I'll fix FindQt5Transitional when it starts to annoy me :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That would work for now, but if/when phonon five is updated further, it might actually need libinqt5. But I guess we will simply have to cross that bridge when we come to it.</pre>
<br />
<p>- Jon</p>
<br />
<p>On October 20th, 2012, 6:56 p.m., Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Phonon.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2012, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is based on my "Phonon five merge and cleanup" patch, and is a step towards building Phonon five on Qt5.
On Qt4 the build system will now insist on "libinqt5" being installed,
which is located in the kdelibs repository in the frameworks branch.
There is, however, no dependancy on the actual KDE Frameworks 5, and
libinqt5 can be build and installed standalone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindPhononInternal.cmake <span style="color: grey">(20220a3)</span></li>
<li>demos/metadatareader/CMakeLists.txt <span style="color: grey">(fe6eb60)</span></li>
<li>demos/phota/CMakeLists.txt <span style="color: grey">(2306c7e)</span></li>
<li>demos/simplecapture/CMakeLists.txt <span style="color: grey">(4a2e1b0)</span></li>
<li>demos/simpleplayer/CMakeLists.txt <span style="color: grey">(6824142)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106970/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>