Patch: Fixes KGlobalSettings::documentPath() warnings.

[Jignesh Kakadiya]

Fixed suggested comments. Local build compiles with no errors.

-Jignesh

On Mon, Jun 11, 2012 at 5:16 PM, David Faure <faure at kde.org> wrote:

> On Monday 11 June 2012 00:34:58 Jignesh Kakadiya wrote:
> > Hi,
> >
> > Attached is the patch which fixes below warning.
> >
> > kinit.cpp:543:78: warning: ‘static QString
> KGlobalSettings::documentPath()’
> > is
> > deprecated (declared at /d/kde/src/5/kdelibs-
> > frameworks/staging/kwidgets/src/utils/kglobalsettings.h:228)
> [-Wdeprecated-
> > declarations]
> >
> > Please review it.
>
> Don't remove the old implementation, it will be needed by other KDE
> modules.
>
> I'm surprised you didn't have to #include <qstandardpaths.h> anywhere, but
> maybe that's because kconfig.h includes it indirectly. You could also
> check if
> you can remove #include <kglobalsettings.h> from any of the files you
> ported,
> in case it was the last occurence of KGlobalSettings in the file.
>
> Looks good, otherwise (assuming you checked that everything compiles, of
> course).
>
> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120611/ba14a0cb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DocumentPath.patch
Type: application/octet-stream
Size: 5612 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120611/ba14a0cb/attachment.obj>