KDE_EXPORT is needed

[Patrick Spendrin]

Am 05.07.2012 12:55, schrieb David Faure:
> On Thursday 05 July 2012 12:32:34 Patrick Spendrin wrote:
>> Am 05.07.2012 09:17, schrieb David Faure:
>>> On Wednesday 04 July 2012 14:26:09 Patrick Spendrin wrote:
>>>> One issue I have found was that KDE_EXPORT and KDE_IMPORT went missing.
>>>>
>>>> KDE_EXPORT and KDE_IMPORT are needed e.g. if you want to export a
>>>> function from a plugin (you never want to import it) meaning that it is
>>>> needed for K_EXPORT_PLUGIN to work properly. In that special case we
>>>> could use Q_DECL_EXPORT but since we can't always rely on Qt being
>>>> available I would prefer if we define those two again.
>>>
>>> Why would Qt not be available, in KDE frameworks !?
>>
>> Well, the macro that generates the export header is likely usable from
>> outside Qt/frameworks, so I bet it should be solved more general as
>> well. 
> 
> OK, so this is really for "other users of the cmake-generated export header", 
> not at all for KDE frameworks or KDE apps, which can just use Q_DECL_EXPORT...
> 

Yes, my local patch for that actually uses Q_DECL_EXPORT, only for the
mentioned reasons I wouldn't use that.

I will put it on reviewboard in a minute.

regards,
Patrick