Review Request: Make kimgio not use kdecore

[Albert Astals Cid]

> On Dec. 29, 2012, 12:23 a.m., David Faure wrote:
> > Looks fine, thanks for that.
> > 
> > BTW what about the .desktop files in kimgio? I think we can get rid of all that, now that Qt has API to query the available image formats?
> > I.e. getting rid of kio/kio/kimageio.{cpp,h}, and using QImage API instead? (it even got support for returning mimetypes, in Qt 5.... hmm maybe our plugins need to be adapted to that, too).
> > 
> > Oh and the plugins need to be ported to the Qt5 plugin mechanism.
> > 
> > Clearly more investigation and work is needed before making this stuff a tier1 framework.
> >

Ok, let's leave the tier1 part out then ;-) Once we require Qt5 we can reevaluate the code changes.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107986/#review24159
-----------------------------------------------------------


On Dec. 28, 2012, 6:08 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107986/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 6:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> The only thing we lose is kDebug->qDebug (commented) imho it's not a huge deal and if in Qt5 qDebug becomes smart like kDebug we can uncomment them. With this change we can move these to a tier1 "thing" which i suggest naming imageplugins.
> 
> 
> Diffs
> -----
> 
>   kimgio/CMakeLists.txt 84e0d6f 
>   kimgio/dds.cpp ff773e7 
>   kimgio/eps.cpp b96a1b3 
>   kimgio/exr.cpp 3322343 
>   kimgio/pcx.cpp f4825c5 
>   kimgio/psd.cpp dd4e5c2 
>   kimgio/ras.cpp 1abbd2c 
>   kimgio/rgb.cpp a04e1cf 
>   kimgio/tga.cpp 4ab352b 
>   kimgio/xcf.cpp 829d258 
> 
> Diff: http://git.reviewboard.kde.org/r/107986/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121229/535b48e6/attachment-0001.html>