<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107986/">http://git.reviewboard.kde.org/r/107986/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2012, 12:23 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine, thanks for that.
BTW what about the .desktop files in kimgio? I think we can get rid of all that, now that Qt has API to query the available image formats?
I.e. getting rid of kio/kio/kimageio.{cpp,h}, and using QImage API instead? (it even got support for returning mimetypes, in Qt 5.... hmm maybe our plugins need to be adapted to that, too).
Oh and the plugins need to be ported to the Qt5 plugin mechanism.
Clearly more investigation and work is needed before making this stuff a tier1 framework.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, let's leave the tier1 part out then ;-) Once we require Qt5 we can reevaluate the code changes.</pre>
<br />
<p>- Albert</p>
<br />
<p>On December 28th, 2012, 6:08 p.m., Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 6:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only thing we lose is kDebug->qDebug (commented) imho it's not a huge deal and if in Qt5 qDebug becomes smart like kDebug we can uncomment them. With this change we can move these to a tier1 "thing" which i suggest naming imageplugins.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kimgio/CMakeLists.txt <span style="color: grey">(84e0d6f)</span></li>
<li>kimgio/dds.cpp <span style="color: grey">(ff773e7)</span></li>
<li>kimgio/eps.cpp <span style="color: grey">(b96a1b3)</span></li>
<li>kimgio/exr.cpp <span style="color: grey">(3322343)</span></li>
<li>kimgio/pcx.cpp <span style="color: grey">(f4825c5)</span></li>
<li>kimgio/psd.cpp <span style="color: grey">(dd4e5c2)</span></li>
<li>kimgio/ras.cpp <span style="color: grey">(1abbd2c)</span></li>
<li>kimgio/rgb.cpp <span style="color: grey">(a04e1cf)</span></li>
<li>kimgio/tga.cpp <span style="color: grey">(4ab352b)</span></li>
<li>kimgio/xcf.cpp <span style="color: grey">(829d258)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107986/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>