Review Request: Fix attica dependency

[Christophe Giboudeaux]

> On Dec. 26, 2012, 9:12 a.m., Christophe Giboudeaux wrote:
> > knewstuff/knewstuff3/CMakeLists.txt, line 21
> > <http://git.reviewboard.kde.org/r/107911/diff/1/?file=101183#file101183line21>
> >
> >     endif()
> >     
> >     Please read http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands
> 
> Valentin Rusu wrote:
>     Oh, glad to see that repeating macros in else and endif is no longer required.

They can be empty since CMake 2.6.0 :-)
What about fixing the Attica build for Qt5 ? would http://paste.kde.org/631772/raw/ help ?


- Christophe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107911/#review23985
-----------------------------------------------------------


On Dec. 26, 2012, 10:28 a.m., Valentin Rusu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107911/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2012, 10:28 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> For the moment Attica won't build with QT5, so it won't install in a KF5/QT5 setup.
> This fix let KF5/QT5 build without Attica.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e5ef86e 
>   knewstuff/knewstuff3/CMakeLists.txt 8653433 
> 
> Diff: http://git.reviewboard.kde.org/r/107911/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Valentin Rusu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121226/b30091fe/attachment.html>