Review Request: Fix attica dependency

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107911/#review23985
-----------------------------------------------------------



knewstuff/knewstuff3/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107911/#comment18265>

    endif()
    
    Please read http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands



knewstuff/knewstuff3/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107911/#comment18266>

    endif()



knewstuff/knewstuff3/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107911/#comment18267>

    else()



knewstuff/knewstuff3/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107911/#comment18268>

    endif()


- Christophe Giboudeaux


On Dec. 25, 2012, 8:26 p.m., Valentin Rusu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107911/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2012, 8:26 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> For the moment Attica won't build with QT5, so it won't install in a KF5/QT5 setup.
> This fix let KF5/QT5 build without Attica.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e5ef86e 
>   knewstuff/knewstuff3/CMakeLists.txt 8653433 
> 
> Diff: http://git.reviewboard.kde.org/r/107911/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Valentin Rusu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121226/b381fe3c/attachment.html>