Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

[Jon Severinsson]

> On Dec. 13, 2012, 9:12 a.m., John Layt wrote:
> > No.  This is very very wrong.  Week day name *does* depend on both calendar and language, as does month name.  This is for a very specific and widely used case for religious calendars in particular where they are used in parallel with the Gregorian.  This scheme was worked out carefully with various user groups in different countries and the translation teams to allow maximum flexibility for each translation team to decide what the common usage is in their language and country.

Month names does of course depend on the calendar system used, but weekday does not. When it is Sunday it is Sunday no matter what calendar system is used or what religion the speaker confesses to, and what you call Sunday depends on what language you are speaking, nothing else.  Whether you place any religious significance to a specific week day (eg. if you consider it a day of rest, aka. a sabbath) will depend on your religion, not the calendar system used, and thus don't belong to KCalendarSystem.

For example, Saturday is called "Shabbath" in Hebrew, no matter if you use the Gregorian or Hebrew calendar system. Two English speaking europeans, one jew and one christian, will both use the Gregorian calendar, will both cal Saturday "Saturday" and Sunday "Sunday", but the jew will consider Saturday a sabbath and the christian will consider Sunday a sabbath. Equivalently two Arabic speaking arabs, one muslim and one christian, will both use the Islamic Civil calendar, will both call Friday "alejm'eh" and Sunday "alejm'ehalahed", but the muslim will consider Friday a sabbath and the christian will consider Sunday a sabbath.


- Jon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107696/#review23392
-----------------------------------------------------------


On Dec. 13, 2012, 7:43 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107696/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 7:43 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Weekday names depend on *lanuage*, not calendar system. The usual ki18nc
> can handle it just fine, so consolidate it all to a single function.
> 
> Note: Between patch 3 and 4 in this series I'm moving some functions to a new file "kcalendarsystemweek.cpp" in order move to out ouf the way of regular calendar system code. That commit changes no code whatsoever, so don't really need a review.
> 
> 
> Diffs
> -----
> 
>   kdecore/date/kcalendarsystem.h efddd08 
>   kdecore/date/kcalendarsystem.cpp 1aed791 
>   kdecore/date/kcalendarsystemcoptic.cpp 0a95dbe 
>   kdecore/date/kcalendarsystemcoptic_p.h 5287271 
>   kdecore/date/kcalendarsystemcopticprivate_p.h 35907ff 
>   kdecore/date/kcalendarsystemethiopian.cpp e2d293f 
>   kdecore/date/kcalendarsystemethiopian_p.h 4f8119e 
>   kdecore/date/kcalendarsystemgregorian.cpp 40db17a 
>   kdecore/date/kcalendarsystemgregorian_p.h 6ba9088 
>   kdecore/date/kcalendarsystemgregorianprivate_p.h fb7a0dd 
>   kdecore/date/kcalendarsystemhebrew.cpp e3d1484 
>   kdecore/date/kcalendarsystemhebrew_p.h 75a6280 
>   kdecore/date/kcalendarsystemindiannational.cpp 7222722 
>   kdecore/date/kcalendarsystemindiannational_p.h 499d2fa 
>   kdecore/date/kcalendarsystemislamiccivil.cpp eea98e2 
>   kdecore/date/kcalendarsystemislamiccivil_p.h 6d4682f 
>   kdecore/date/kcalendarsystemjalali.cpp 889a060 
>   kdecore/date/kcalendarsystemjalali_p.h c88d304 
>   kdecore/date/kcalendarsystemjapanese.cpp dbbf94b 
>   kdecore/date/kcalendarsystemjapanese_p.h 09bb4f4 
>   kdecore/date/kcalendarsystemjulian.cpp 9bfc5f9 
>   kdecore/date/kcalendarsystemjulian_p.h 5940c27 
>   kdecore/date/kcalendarsystemminguo.cpp 6761f63 
>   kdecore/date/kcalendarsystemminguo_p.h 0a3b5d7 
>   kdecore/date/kcalendarsystemprivate_p.h d935ead 
>   kdecore/date/kcalendarsystemqdate.cpp f233d219 
>   kdecore/date/kcalendarsystemqdate_p.h 9363fff 
>   kdecore/date/kcalendarsystemweek.cpp PRE-CREATION 
>   kdecore/tests/kcalendartest.h 505c137 
>   kdecore/tests/kcalendartest.cpp 85d790d 
> 
> Diff: http://git.reviewboard.kde.org/r/107696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121213/6c6f9388/attachment-0001.html>