Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

[Jon Severinsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107696/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

Weekday names depend on *lanuage*, not calendar system. The usual ki18nc
can handle it just fine, so consolidate it all to a single function.

Note: Between patch 3 and 4 in this series I'm moving some functions to a new file "kcalendarsystemweek.cpp" in order move to out ouf the way of regular calendar system code. That commit changes no code whatsoever, so don't really need a review.


Diffs
-----

  kdecore/date/kcalendarsystem.h efddd08 
  kdecore/date/kcalendarsystem.cpp 1aed791 
  kdecore/date/kcalendarsystemcoptic.cpp 0a95dbe 
  kdecore/date/kcalendarsystemcoptic_p.h 5287271 
  kdecore/date/kcalendarsystemcopticprivate_p.h 35907ff 
  kdecore/date/kcalendarsystemethiopian.cpp e2d293f 
  kdecore/date/kcalendarsystemethiopian_p.h 4f8119e 
  kdecore/date/kcalendarsystemgregorian.cpp 40db17a 
  kdecore/date/kcalendarsystemgregorian_p.h 6ba9088 
  kdecore/date/kcalendarsystemgregorianprivate_p.h fb7a0dd 
  kdecore/date/kcalendarsystemhebrew.cpp e3d1484 
  kdecore/date/kcalendarsystemhebrew_p.h 75a6280 
  kdecore/date/kcalendarsystemindiannational.cpp 7222722 
  kdecore/date/kcalendarsystemindiannational_p.h 499d2fa 
  kdecore/date/kcalendarsystemislamiccivil.cpp eea98e2 
  kdecore/date/kcalendarsystemislamiccivil_p.h 6d4682f 
  kdecore/date/kcalendarsystemjalali.cpp 889a060 
  kdecore/date/kcalendarsystemjalali_p.h c88d304 
  kdecore/date/kcalendarsystemjapanese.cpp dbbf94b 
  kdecore/date/kcalendarsystemjapanese_p.h 09bb4f4 
  kdecore/date/kcalendarsystemjulian.cpp 9bfc5f9 
  kdecore/date/kcalendarsystemjulian_p.h 5940c27 
  kdecore/date/kcalendarsystemminguo.cpp 6761f63 
  kdecore/date/kcalendarsystemminguo_p.h 0a3b5d7 
  kdecore/date/kcalendarsystemprivate_p.h d935ead 
  kdecore/date/kcalendarsystemqdate.cpp f233d219 
  kdecore/date/kcalendarsystemqdate_p.h 9363fff 
  kdecore/date/kcalendarsystemweek.cpp PRE-CREATION 
  kdecore/tests/kcalendartest.h 505c137 
  kdecore/tests/kcalendartest.cpp 85d790d 

Diff: http://git.reviewboard.kde.org/r/107696/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121213/551e7569/attachment.html>