Review Request: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

Jon Severinsson jon at severinsson.net
Thu Dec 13 07:41:46 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107690/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

These only depend on the week system (i.e. KLocale::WeekNumberSystem) used, not the calendar used, and thus need not be (d-pointer) virtual.


Diffs
-----

  kdecore/date/kcalendarsystem.h efddd08 
  kdecore/date/kcalendarsystem.cpp 1aed791 
  kdecore/date/kcalendarsystemprivate_p.h d935ead 

Diff: http://git.reviewboard.kde.org/r/107690/diff/


Testing
-------


Thanks,

Jon Severinsson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121213/956ca438/attachment.html>


More information about the Kde-frameworks-devel mailing list