KF5 Unit test results

[David Faure]

On Sunday 19 August 2012 14:59:29 Rolf Eike Beer wrote:
> David Faure wrote:
> > Update:
> > 
> > * kdelibs-frameworks with Qt4:
> > 
> > 100% tests passed, 0 tests failed out of 126
> > 
> > (I fixed the plasma tests)
> > 
> > * kdelibs-frameworks with Qt5:
> > 
> > The following tests FAILED:
> > 108 - httpheaderdispositiontest (Failed) [**]
> > 
> > [**]
> > FAIL!  : HeaderDispositionTest::runAllTests(greenbytes-attwithisofnplain)
> > Compared values are not the same Actual   (parameters[key]): foo-?.html
> > 
> >    Expected (QString::fromUtf8(val.constData(), val.length())): foo-?.html
> > 
> >    Loc:
> > [/d/kde/src/kf5-qt5/kdelibs-frameworks/kioslave/http/tests/httpheaderdispo
> > s
> > itiontest.cpp(52)] Rolf, any change you can have a look?
> 
>     QTest::newRow("greenbytes-attwithisofnplain") << "attachment;
> filename=\"foo-\xe4.html\"" <<
>                   QByteArray("type\tattachment\n"
>                              "filename\tfoo-ä.html");
> 
> Qt5 does not take the string as ISO-8859-1 anymore, so the input is not what
> the testcase expects so the output is also broken.
> 
> Merge KDE/4.9 (which contains commit
> b6a802bfab579880612740e7f9da2569fcd900cd) into master and frameworks, this
> should fix it.

Thanks, well spotted!
I applied the same fix to three other lines, and the test passes now.
7 to go ;-)

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5