KF5 Unit test results

Rolf Eike Beer kde at opensource.sf-tec.de
Sun Aug 19 12:59:29 UTC 2012


David Faure wrote:
> Update:
> 
> * kdelibs-frameworks with Qt4:
> 
> 100% tests passed, 0 tests failed out of 126
> 
> (I fixed the plasma tests)
> 
> * kdelibs-frameworks with Qt5:
> 
> The following tests FAILED:
> 108 - httpheaderdispositiontest (Failed) [**]
> 
> [**]
> FAIL!  : HeaderDispositionTest::runAllTests(greenbytes-attwithisofnplain)
> Compared values are not the same Actual   (parameters[key]): foo-?.html
>    Expected (QString::fromUtf8(val.constData(), val.length())): foo-?.html
>    Loc:
> [/d/kde/src/kf5-qt5/kdelibs-frameworks/kioslave/http/tests/httpheaderdispos
> itiontest.cpp(52)] Rolf, any change you can have a look?

    QTest::newRow("greenbytes-attwithisofnplain") << "attachment; 
filename=\"foo-\xe4.html\"" <<
                  QByteArray("type\tattachment\n"
                             "filename\tfoo-ä.html");

Qt5 does not take the string as ISO-8859-1 anymore, so the input is not what 
the testcase expects so the output is also broken.

Merge KDE/4.9 (which contains commit b6a802bfab579880612740e7f9da2569fcd900cd) 
into master and frameworks, this should fix it.

   || ||
   \/ \/
--> Eike <--
   /\ /\
   || ||
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120819/9eff1544/attachment.sig>


More information about the Kde-frameworks-devel mailing list