Review Request: Remove uses of KApplication where not needed

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106063/#review17640
-----------------------------------------------------------



kdeui/tests/klineedittest.cpp
<http://git.reviewboard.kde.org/r/106063/#comment13806>

    Why is the third arg (GUIenabled) set to false, in a GUI program? This sounds like it will abort on startup...
    
    Same problem in many other programs, in this change. Any time the original source code didn't set false, you should remove the "false".
    
    Looks good otherwise, thanks!


- David Faure


On Aug. 17, 2012, 8:03 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106063/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2012, 8:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Remove uses of KApplication where not needed
> 
> 
> Diffs
> -----
> 
>   kdeui/shortcuts/kgesturemap.h ae6d60d29f2fafd7c89df015eb3d1f4cf5269e83 
>   kdeui/shortcuts/kgesturemap.cpp d504ec7c6139ab456a5a1bbfb8642629c6053dbe 
>   kdeui/tests/klineedittest.cpp f0cec27ce8b29b866cb13365c2512c0ffb3a74fc 
>   kdeui/tests/kpixmapregionselectordialogtest.cpp a78ee4f4d4db5289715f0833b4a1fc6c1cf4a908 
>   kdeui/tests/kstatusnotifieritemtest.cpp 1f478fedc94bc86791b9b9273fd3bdae8c503f03 
>   kdeui/tests/testqtargs.cpp a43ff9a1f8b801db965acb22c42019c54f085cb0 
>   kfile/tests/kdirselectdialogtest.cpp 90af42c5598ac5dfab4552c0c588148a4d9aea17 
>   khtml/java/tests/testkjavaappletserver.cpp df8528945386cab89697fdaeca76989e5fce8fa3 
>   khtml/test_regression.cpp 68c861ffc34f972f365dee7010e576c005fead05 
>   khtml/testkhtml.cpp 8cc92c548201d0acbccd0657a21fa996d4258fda 
>   khtml/tests/testkhtmlnew.cpp 335d2e11f71fdcbb8a1b3534d8b874b3477ec24a 
>   kio/misc/kmailservice.cpp dfa7851b0deece231f1369322af9b9e0a41f82d8 
>   kio/misc/ksendbugmail/main.cpp b1442416c607858cc25c6f12d38de42f16024a49 
>   kio/misc/ktelnetservice.cpp 337df66113b5b3dbc5425ab24dd9080c7117303c 
>   kio/tests/kdirmodeltest_gui.cpp a05c42bf1db7de1cf779110ba871428c56a9013b 
>   kio/tests/kfstest.cpp d3835d5ef5e2ed3c0d8b80ab6110653f7609fe67 
>   kio/tests/kionetrctest.cpp 4c5beb718617e58d0aba8e9cf72c58320735b21d 
>   kio/tests/kioslavetest.cpp e96af3b1fc1b67be446ebdfc654394a14add1e64 
>   kio/tests/kpropsdlgtest.cpp 0ee8ad42ef9fa3d7f49ec0e9c15e46751db3f6dc 
>   kio/tests/speed.cpp 1d3034c7a1f24eb21bda0c825697abef5beea9ec 
>   knewstuff/tests/knewstuff2_standard.cpp 108c821757d38a00b65a602740502ce3774af31c 
>   knewstuff/tests/knewstuff2_test.cpp 767bbcb37bae1cbf5052ccede43f4beeeb2c4676 
>   kparts/tests/partviewer.cpp 00abea7b96719a5c6675f710b004edad653eb272 
>   kross/console/main.cpp 6bdad00326e4cb93eca88fa05dcffd72fd01ff77 
>   kross/qts/main.cpp 2ad81400f03446abc8b1543330ad7b389f311a08 
>   kross/test/main.cpp b907a90541e65badec1d948039688445f1cafe09 
> 
> Diff: http://git.reviewboard.kde.org/r/106063/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120818/6d403fac/attachment.html>