<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106063/">http://git.reviewboard.kde.org/r/106063/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106063/diff/1/?file=78268#file78268line198" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/tests/klineedittest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KLineEditTest::slotInvalidChar(int key)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">197</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KApplication</span> <span class="n">a</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">197</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QApplication</span> <span class="n">a</span><span class="p">(</span><span class="n">KCmdLineArgs</span><span class="o">::</span><span class="n">qtArgc</span><span class="p">(),</span> <span class="n">KCmdLineArgs</span><span class="o">::</span><span class="n">qtArgv</span><span class="p">(),</span> <span class="kc">false</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is the third arg (GUIenabled) set to false, in a GUI program? This sounds like it will abort on startup...
Same problem in many other programs, in this change. Any time the original source code didn't set false, you should remove the "false".
Looks good otherwise, thanks!</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On August 17th, 2012, 8:03 p.m., Jeremy Paul Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2012, 8:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove uses of KApplication where not needed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/shortcuts/kgesturemap.h <span style="color: grey">(ae6d60d29f2fafd7c89df015eb3d1f4cf5269e83)</span></li>
<li>kdeui/shortcuts/kgesturemap.cpp <span style="color: grey">(d504ec7c6139ab456a5a1bbfb8642629c6053dbe)</span></li>
<li>kdeui/tests/klineedittest.cpp <span style="color: grey">(f0cec27ce8b29b866cb13365c2512c0ffb3a74fc)</span></li>
<li>kdeui/tests/kpixmapregionselectordialogtest.cpp <span style="color: grey">(a78ee4f4d4db5289715f0833b4a1fc6c1cf4a908)</span></li>
<li>kdeui/tests/kstatusnotifieritemtest.cpp <span style="color: grey">(1f478fedc94bc86791b9b9273fd3bdae8c503f03)</span></li>
<li>kdeui/tests/testqtargs.cpp <span style="color: grey">(a43ff9a1f8b801db965acb22c42019c54f085cb0)</span></li>
<li>kfile/tests/kdirselectdialogtest.cpp <span style="color: grey">(90af42c5598ac5dfab4552c0c588148a4d9aea17)</span></li>
<li>khtml/java/tests/testkjavaappletserver.cpp <span style="color: grey">(df8528945386cab89697fdaeca76989e5fce8fa3)</span></li>
<li>khtml/test_regression.cpp <span style="color: grey">(68c861ffc34f972f365dee7010e576c005fead05)</span></li>
<li>khtml/testkhtml.cpp <span style="color: grey">(8cc92c548201d0acbccd0657a21fa996d4258fda)</span></li>
<li>khtml/tests/testkhtmlnew.cpp <span style="color: grey">(335d2e11f71fdcbb8a1b3534d8b874b3477ec24a)</span></li>
<li>kio/misc/kmailservice.cpp <span style="color: grey">(dfa7851b0deece231f1369322af9b9e0a41f82d8)</span></li>
<li>kio/misc/ksendbugmail/main.cpp <span style="color: grey">(b1442416c607858cc25c6f12d38de42f16024a49)</span></li>
<li>kio/misc/ktelnetservice.cpp <span style="color: grey">(337df66113b5b3dbc5425ab24dd9080c7117303c)</span></li>
<li>kio/tests/kdirmodeltest_gui.cpp <span style="color: grey">(a05c42bf1db7de1cf779110ba871428c56a9013b)</span></li>
<li>kio/tests/kfstest.cpp <span style="color: grey">(d3835d5ef5e2ed3c0d8b80ab6110653f7609fe67)</span></li>
<li>kio/tests/kionetrctest.cpp <span style="color: grey">(4c5beb718617e58d0aba8e9cf72c58320735b21d)</span></li>
<li>kio/tests/kioslavetest.cpp <span style="color: grey">(e96af3b1fc1b67be446ebdfc654394a14add1e64)</span></li>
<li>kio/tests/kpropsdlgtest.cpp <span style="color: grey">(0ee8ad42ef9fa3d7f49ec0e9c15e46751db3f6dc)</span></li>
<li>kio/tests/speed.cpp <span style="color: grey">(1d3034c7a1f24eb21bda0c825697abef5beea9ec)</span></li>
<li>knewstuff/tests/knewstuff2_standard.cpp <span style="color: grey">(108c821757d38a00b65a602740502ce3774af31c)</span></li>
<li>knewstuff/tests/knewstuff2_test.cpp <span style="color: grey">(767bbcb37bae1cbf5052ccede43f4beeeb2c4676)</span></li>
<li>kparts/tests/partviewer.cpp <span style="color: grey">(00abea7b96719a5c6675f710b004edad653eb272)</span></li>
<li>kross/console/main.cpp <span style="color: grey">(6bdad00326e4cb93eca88fa05dcffd72fd01ff77)</span></li>
<li>kross/qts/main.cpp <span style="color: grey">(2ad81400f03446abc8b1543330ad7b389f311a08)</span></li>
<li>kross/test/main.cpp <span style="color: grey">(b907a90541e65badec1d948039688445f1cafe09)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106063/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>