Review Request: Make kcodecs framework build standalone
George Goldberg
grundleborg at googlemail.com
Wed Aug 8 14:07:37 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105860/
-----------------------------------------------------------
(Updated Aug. 8, 2012, 2:07 p.m.)
Review request for KDE Frameworks and David Faure.
Changes
-------
Fix all David's comments and use Ossi's solution to the QT_TRANSLATE_NOOP3 problem.
Description
-------
Make it possible to build kcodecs independently of the whole kdelibs-frameworks tree.
Diffs (updated)
-----
tier1/kcodecs/CMakeLists.txt 22463ca0345e6d50384c17bf5f43824e3445b55f
tier1/kcodecs/src/kcharsets.cpp c64aa12361583cd9184bc39495c7149e6b0d7796
tier1/kcodecs/src/kencodingprober.cpp 1dad3272986c2b0c693cd1bbf49fd40055300e39
Diff: http://git.reviewboard.kde.org/r/105860/diff/
Testing
-------
Works for me, both standalone and as part of kdelibs
Thanks,
George Goldberg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120808/3431b90d/attachment.html>
More information about the Kde-frameworks-devel
mailing list