Review Request: Make kcodecs framework build standalone
Oswald Buddenhagen
ossi at kde.org
Tue Aug 7 07:23:02 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105860/#review17017
-----------------------------------------------------------
tier1/kcodecs/src/kcharsets.cpp
<http://git.reviewboard.kde.org/r/105860/#comment13365>
you can just re-define QT_TRANSLATE_NOOP3 to expand to only the main string, then you can keep the old structure.
- Oswald Buddenhagen
On Aug. 5, 2012, 2:24 p.m., George Goldberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105860/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2012, 2:24 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Description
> -------
>
> Make it possible to build kcodecs independently of the whole kdelibs-frameworks tree.
>
>
> Diffs
> -----
>
> tier1/kcodecs/CMakeLists.txt 22463ca0345e6d50384c17bf5f43824e3445b55f
> tier1/kcodecs/src/kcharsets.cpp c64aa12361583cd9184bc39495c7149e6b0d7796
> tier1/kcodecs/src/kencodingprober.cpp 1dad3272986c2b0c693cd1bbf49fd40055300e39
>
> Diff: http://git.reviewboard.kde.org/r/105860/diff/
>
>
> Testing
> -------
>
> Works for me, both standalone and as part of kdelibs
>
>
> Thanks,
>
> George Goldberg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120807/8349d9a1/attachment.html>
More information about the Kde-frameworks-devel
mailing list