Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

Mon Aug 6 19:53:08 UTC 2012

I didn't check the make test against the result you are getting on the main
branch, no.  I'll remove the KAboutData from these and check that.  Some of
these KAboutData have quite a bit in them, is it ok to nuke them?

I also found one KApplication usage in an io slave that's part of the
patch, is that ok to port to QApplication? or is there something that
KApplication brings that it needs (does kquitapp blah work on QApplications
for example)?

Jeremy

On Mon, Aug 6, 2012 at 1:47 PM, David Faure <faure at kde.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105897/
>
> Thanks, a good start.
>
> BTW did you try running the tests afterwards, to see if this breaks anything? (see the list for current expected results). Otherwise I will.
>
>
>    interfaces/terminal/example/main.cc<http://git.reviewboard.kde.org/r/105897/diff/1/?file=76335#file76335line32> (Diff
> revision 1)
>
> int main( int argc, char** argv )
>
>   32
>
>     KAboutData* about = new KAboutData( "tetest", 0, ki18n("TETest"), "0.1" );
>
> 31
>
>     KAboutData* about = new KAboutData( "tetest", 0, ki18n("TETest"), "0.1" );
>
>   The KAboutData instance is unnecessary now, and can be removed.
>
>
>    kde3support/tests/kactivelabeltest.cpp<http://git.reviewboard.kde.org/r/105897/diff/1/?file=76340#file76340line48> (Diff
> revision 1)
>
> KActiveLabelTest::KActiveLabelTest(QWidget *parent)
>
>   47
>
>   KCmdLineArgs::init(argc, argv, &about);
>
> 46
>
>   QApplication::setApplicationName(about.appName());
>
>   Same here, and in most others.
> I would just do setApplicationName("KActiveLabelTest"),
> the KAboutData isn't useful (it's not even registered anywhere anymore, as kcmdlineargs used to do).
>
>
> - David
>
> On August 6th, 2012, 6:53 p.m., Jeremy Paul Whiting wrote:
>   Review request for KDE Frameworks and David Faure.
> By Jeremy Paul Whiting.
>
> *Updated Aug. 6, 2012, 6:53 p.m.*
> Description
>
> Port from KApplication KCmdLineArgs to QApplication in unit tests.
>
>   Diffs
>
>    - interfaces/terminal/example/main.cc
>    (40c1f01c001a04e1d9ad538a52e4be93a827535d)
>    - kde3support/tests/itemcontainertest.cpp
>    (3fa45262cf43958118caf6d2c13e3cbe7052adce)
>    - kde3support/tests/k3listviewtest.cpp
>    (fade590e4bb40a8d90555adf930e16dac1c3a2f8)
>    - kde3support/tests/k3wizardtest.cpp
>    (39dbd5717c6860af82b19f236b8e951194e875c5)
>    - kde3support/tests/kaboutdialogtest.cpp
>    (631144986b33497382ad46d260ae43aca100efbf)
>    - kde3support/tests/kactivelabeltest.cpp
>    (4653a94cad4276ea44f6436a2baf46e296138136)
>    - kde3support/tests/kdocktest.cpp
>    (7a0bd770377e0123e80d1ffb5c633751a96e9e71)
>    - kde3support/tests/kdockwidgetdemo.cpp
>    (cba54ba922ba259f28c3d6b95379c539a70fed03)
>    - kde3support/tests/kdockwidgettest.cpp
>    (8247e21e783506d0f31b13cc739c770a580e2f92)
>    - kdeui/tests/kanimatedbuttontest.cpp
>    (9f9d77071e788b8289fd84620aa515bcd40cd621)
>    - kdeui/tests/kassistantdialogtest.cpp
>    (9d90824027acc57dd68ad1ab6c946d3ffac67098)
>    - kdeui/tests/kbugreporttest.cpp
>    (6b6cd4c6c839e4f462803fd9666042c65a982602)
>    - kdeui/tests/kcategorizedviewtest.cpp
>    (5c78e77a0884a02857f8fd898e70efc080e7d708)
>    - kdeui/tests/kcharselecttest.cpp
>    (b519c542149d2244977d0478a0e2f0edd1edd9b0)
>    - kdeui/tests/kcodecactiontest.cpp
>    (6d7004340ffbeef24659a7d654baf13c996ba3d8)
>    - kdeui/tests/kcolorcollectiontest.cpp
>    (8262213c94c9318955fc90b4ac4fc69b709cce99)
>    - kdeui/tests/kcolordlgtest.cpp
>    (28d52c558a2161209d8fbed70d3bd78d81659bbf)
>    - kdeui/tests/kcolorutilsdemo.cpp
>    (a6bb914b81f7f9b529164bc8faa133580c3c51e4)
>    - kdeui/tests/kcomboboxtest.cpp
>    (ec453987cd204bc65924ad5bd2c8e58a5ecec390)
>    - kdeui/tests/kcompletionuitest.cpp
>    (6ab5444294cfab76b52bbfc4dd53c7e01f7296cf)
>    - kdeui/tests/kdatepicktest.cpp
>    (620ff7adc0fa815bcd8ca8fdfbc5d16ee964e63b)
>    - kdeui/tests/kdatetabletest.cpp
>    (43e31d76e260e0a1e63118311874c7cb97f36deb)
>    - kdeui/tests/kdatetimewidgettest.cpp
>    (39e05c0c6d514ba61c4dd4279a4fd3b31cb0638e)
>    - kdeui/tests/kdatewidgettest.cpp
>    (2f8b568ffd336fcd5d6d714d606db0ee8db0bc5b)
>    - kdeui/tests/keditlistboxtest.cpp
>    (d0713e06c7e292dbd88a551d5aa845c303502c39)
>    - kdeui/tests/kfontdialogtest.cpp
>    (01cf2dae03ec0eb4b795b77ecf90a4915b649e0e)
>    - kdeui/tests/kjobtrackerstest.cpp
>    (3168cb84199c5a2798ddefb967855e89ad2172f3)
>    - kdeui/tests/kmainwindowrestoretest.cpp
>    (926613e003f0ac562126b6c3ab5f073ef3560768)
>    - kdeui/tests/kmainwindowtest.cpp
>    (10b8db582ccdbf521084e3b35624ff6c728bfc3e)
>    - kdeui/tests/kmanagerselectiontest.cpp
>    (e447ae267bdf328577fa767a2f18cf1b769a9039)
>    - kdeui/tests/kmessagetest.cpp
>    (f6f1b869894d6fea7721a636d817b9dd33ad7b56)
>    - kdeui/tests/kmodifierkeyinfotest.cpp
>    (1a5beeba45d4166497c85ab17ad2d6b90b89593d)
>    - kdeui/tests/knewpassworddialogtest.cpp
>    (1ecb81a7d6a2da150cb1cc811c930679c73c5dfe)
>    - kdeui/tests/knuminputtest.cpp
>    (a8c6a2c6c226dabb8c726685419f5cc4b962b734)
>    - kdeui/tests/kpagedialogtest.cpp
>    (65f90f9586eead6fd626230522d53fed7def4b4d)
>    - kdeui/tests/kpagewidgettest.cpp
>    (d8c4983eb4c2b1309770601c2a8d2a2334afc888)
>    - kdeui/tests/kpassivepopuptest.cpp
>    (b0192251a4dd2f121d9c1a37a30da6db4c099742)
>    - kdeui/tests/kpassworddialogtest.cpp
>    (11862b04475a9398d24df47489e8d210453c74ba)
>    - kdeui/tests/kpixmapsequenceoverlaypaintertest.cpp
>    (04d2b3358d1262a4275e8264bd3555ce670b66d9)
>    - kdeui/tests/kpopuptest.cpp (a85f1bc387acda46a5ac4570a7c942b485a08523)
>    - kdeui/tests/kprogressdialogtest.cpp
>    (8be3beff144c44e3774f6dbdc7412122071e30d7)
>    - kdeui/tests/kreplacetest.cpp
>    (294a0cf46c4931d931a5dab68b5e2c7717060312)
>    - kdeui/tests/krichtexteditor/main.cpp
>    (92fa2577eb31f2f99377c8bf7f427a857b98d11c)
>    - kdeui/tests/krulertest.cpp (9a22b0f3926af85329c6aaac6db19c85d13a593a)
>    - kdeui/tests/kselectactiontest.cpp
>    (d72abe51e6a9232eb5dcc13fa3094ea7f184f071)
>    - kdeui/tests/ksqueezedtextlabeltest.cpp
>    (2f25aaab6c00f71dec6a68a4f3488ebc9526061f)
>    - kdeui/tests/kstatusbartest.cpp
>    (59e9ef10a49b1f215e26aa6ba3baf128ff2e87e3)
>    - kdeui/tests/ksystemtraytest.cpp
>    (5248bdc0532837f1f0c6a131d93bd8f336260796)
>    - kdeui/tests/ktabwidgettest.cpp
>    (477ac7b6a71f501a8518c632f0d5c6d48256f716)
>    - kdeui/tests/ktextbrowsertest.cpp
>    (4d15ea2affa6194cfbf30151999aa9cac6a04efe)
>    - kdeui/tests/ktextedittest.cpp
>    (d605bfc46584828aa1391d68c58bc80a58428ac8)
>    - kdeui/tests/ktitlewidgettest.cpp
>    (c22d68f7ad4d53dbca745850d12c14825ebacacf)
>    - kdeui/tests/ktoolbarlabelactiontest.cpp
>    (fa6e7ba31b6af2a3639ba77665171388e7c2653f)
>    - kdeui/tests/ktoolbartest.cpp
>    (b1159dea61c2e9c88182c912d829bb4090bc5660)
>    - kdeui/tests/ktreewidgetsearchlinetest.cpp
>    (e2047c3446858d2d8629cb0f3fb6083cce0a5c15)
>    - kdeui/tests/kwidgetitemdelegatetest.cpp
>    (03ec36adb47e1b386806a1b3ccb43ac210167daf)
>    - kdeui/tests/kwindowtest.cpp
>    (e435b0ca66a631bcb9dc8dd3c085aea0d82846ac)
>    - kdeui/tests/kxmlguitest.cpp
>    (6bd9c8973d34a8491e587d1521dba9655584a7db)
>    - kdeui/tests/kxmlguiwindowtest.cpp
>    (8f0162b525f0fe028034d6aeb5367cf511d3e653)
>    - kfile/tests/kfiletreeviewtest.cpp
>    (137a373b46fd0d1421c7c491675cf3cc3a28faaf)
>    - khtml/test_regression_gui_main.cpp
>    (c97854fbd601d4af8f74cc05c277608b6adf914b)
>    - khtml/xpath/interpreter_tester.cpp
>    (88da20b484b40279d266a6455e416b58f6f7c410)
>    - kio/tests/getalltest.cpp (35233e238beb3506b17e7ae69623412192c40989)
>    - kio/tests/kacltest.cpp (91293c972b75a1ea29be7de22fead0cb614d56ed)
>    - kio/tests/kdbusservicestartertest.cpp
>    (4bdfb3d8aa6769068bf4ee7fab1b4ca664ebbe22)
>    - kio/tests/kdirlistertest_gui.cpp
>    (416ff31f6c18d56cf9f122f738c449a0591a7a97)
>    - kio/tests/kfiledialogtest.cpp
>    (8e1f521f79cc863ba617765d46cca2aca0774983)
>    - kio/tests/kiopassdlgtest.cpp
>    (cf0b48cedc824b041ff583150adb103534b2072f)
>    - kio/tests/kopenwithtest.cpp
>    (b6c2a5e17ac247f0c4cd40c5d4a2bb6110adda6a)
>    - kio/tests/kruntest.cpp (14482555abab2e12cf3af8a88a61518c1e8f9a99)
>    - kio/tests/kscantest.cpp (88d8f56092c1b274657ed55cbeb532428057776b)
>    - kio/tests/ksycocatest.cpp (cecb8aaf1836914e39bb00fc94b2e88c5f6333e3)
>    - kio/tests/ksycocaupdatetest.cpp
>    (ff82f87a5b5b4415630e81a45986e237637d528b)
>    - kio/tests/netaccesstest.cpp
>    (a3e6b086185217e887c85a2f3a825e59341147b9)
>    - kioslave/metainfo/metainfo.cpp
>    (793b84dd9f065d11b487a255be8a703a1d380a5d)
>    - knewstuff/tests/kdxspreview.cpp
>    (26cda4eeba4ad73f4a0d896cc61653002065b05e)
>    - knewstuff/tests/knewstuff2_cache.cpp
>    (e8b2d87452557a2ab304dcac77fd042934d0cc91)
>    - knewstuff/tests/knewstuff2_download.cpp
>    (974704a9bc55a2b61c306875316e0b7fe02c69f7)
>    - knotify/tests/main.cpp (b22f0574a8c11c1c0a16fcce20baa77ec33af4c4)
>    - kparts/tests/normalktm.cpp (997601b67237386db9ecceac385de7efc5f2bb2a)
>    - kparts/tests/openorsavequestion.cpp
>    (f534dfacc9d1fc33511cbed7a25bc7a33be6861a)
>    - kparts/tests/testmainwindow.cpp
>    (8468ce84d5fb5768857d675db50d1ab4a747ee00)
>    - kutils/kemoticons/tests/main.cpp
>    (5f0933a545d2699604b4be672a317ade57cfd5f2)
>
> View Diff <http://git.reviewboard.kde.org/r/105897/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120806/046d619c/attachment.html>