I didn't check the make test against the result you are getting on the main branch, no. I'll remove the KAboutData from these and check that. Some of these KAboutData have quite a bit in them, is it ok to nuke them?<br>
<br>I also found one KApplication usage in an io slave that's part of the patch, is that ok to port to QApplication? or is there something that KApplication brings that it needs (does kquitapp blah work on QApplications for example)?<br>
<br>Jeremy<br><br><div class="gmail_quote">On Mon, Aug 6, 2012 at 1:47 PM, David Faure <span dir="ltr"><<a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105897/" target="_blank">http://git.reviewboard.kde.org/r/105897/</a>
</td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Thanks, a good start.
BTW did you try running the tests afterwards, to see if this breaks anything? (see the list for current expected results). Otherwise I will.</pre>
<br>
<div>
<table bgcolor="white" border="0" width="100%">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left" bgcolor="#F0F0F0">
<a href="http://git.reviewboard.kde.org/r/105897/diff/1/?file=76335#file76335line32" style="text-decoration:underline;font-weight:bold" target="_blank">interfaces/terminal/example/main.cc</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">int main( int argc, char** argv )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" bgcolor="#f0f0f0"><font>32</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>KAboutData</span><span>*</span> <span>about</span> <span>=</span> <span>new</span> <span>KAboutData</span><span>(</span> <span>"tetest"</span><span>,</span> <span>0</span><span>,</span> <span>ki18n</span><span>(</span><span>"TETest"</span><span>),</span> <span>"0.1"</span> <span>);</span></pre>
</td>
<th style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" bgcolor="#f0f0f0"><font>31</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>KAboutData</span><span>*</span> <span>about</span> <span>=</span> <span>new</span> <span>KAboutData</span><span>(</span> <span>"tetest"</span><span>,</span> <span>0</span><span>,</span> <span>ki18n</span><span>(</span><span>"TETest"</span><span>),</span> <span>"0.1"</span> <span>);</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">The KAboutData instance is unnecessary now, and can be removed.</pre>
</div>
<br>
<div>
<table bgcolor="white" border="0" width="100%">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px 8px;text-align:left" bgcolor="#F0F0F0">
<a href="http://git.reviewboard.kde.org/r/105897/diff/1/?file=76340#file76340line48" style="text-decoration:underline;font-weight:bold" target="_blank">kde3support/tests/kactivelabeltest.cpp</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre style="font-size:8pt;line-height:140%;margin:0">KActiveLabelTest::KActiveLabelTest(QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" bgcolor="#e9eaa8"><font>47</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>KCmdLineArgs</span><span>::</span><span>init</span><span>(</span><span>argc</span><span>,</span> <span>argv</span><span>,</span> <span>&</span><span>about</span><span>);</span></pre>
</td>
<th style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" bgcolor="#e9eaa8"><font>46</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>QApplication</span><span>::</span><span>setApplicationName</span><span>(</span><span>about</span><span>.</span><span>appName</span><span>());</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Same here, and in most others.
I would just do setApplicationName("KActiveLabelTest"),
the KAboutData isn't useful (it's not even registered anywhere anymore, as kcmdlineargs used to do).</pre><span class="HOEnZb"><font color="#888888">
</font></span></div><span class="HOEnZb"><font color="#888888">
<br>
<p>- David</p></font></span><div><div class="h5">
<br>
<p>On August 6th, 2012, 6:53 p.m., Jeremy Paul Whiting wrote:</p>
<table style="background-image:url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png');background-repeat:repeat-x;border:1px black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color:grey"><i>Updated Aug. 6, 2012, 6:53 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Port from KApplication KCmdLineArgs to QApplication in unit tests.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>interfaces/terminal/example/main.cc <span style="color:grey">(40c1f01c001a04e1d9ad538a52e4be93a827535d)</span></li>
<li>kde3support/tests/itemcontainertest.cpp <span style="color:grey">(3fa45262cf43958118caf6d2c13e3cbe7052adce)</span></li>
<li>kde3support/tests/k3listviewtest.cpp <span style="color:grey">(fade590e4bb40a8d90555adf930e16dac1c3a2f8)</span></li>
<li>kde3support/tests/k3wizardtest.cpp <span style="color:grey">(39dbd5717c6860af82b19f236b8e951194e875c5)</span></li>
<li>kde3support/tests/kaboutdialogtest.cpp <span style="color:grey">(631144986b33497382ad46d260ae43aca100efbf)</span></li>
<li>kde3support/tests/kactivelabeltest.cpp <span style="color:grey">(4653a94cad4276ea44f6436a2baf46e296138136)</span></li>
<li>kde3support/tests/kdocktest.cpp <span style="color:grey">(7a0bd770377e0123e80d1ffb5c633751a96e9e71)</span></li>
<li>kde3support/tests/kdockwidgetdemo.cpp <span style="color:grey">(cba54ba922ba259f28c3d6b95379c539a70fed03)</span></li>
<li>kde3support/tests/kdockwidgettest.cpp <span style="color:grey">(8247e21e783506d0f31b13cc739c770a580e2f92)</span></li>
<li>kdeui/tests/kanimatedbuttontest.cpp <span style="color:grey">(9f9d77071e788b8289fd84620aa515bcd40cd621)</span></li>
<li>kdeui/tests/kassistantdialogtest.cpp <span style="color:grey">(9d90824027acc57dd68ad1ab6c946d3ffac67098)</span></li>
<li>kdeui/tests/kbugreporttest.cpp <span style="color:grey">(6b6cd4c6c839e4f462803fd9666042c65a982602)</span></li>
<li>kdeui/tests/kcategorizedviewtest.cpp <span style="color:grey">(5c78e77a0884a02857f8fd898e70efc080e7d708)</span></li>
<li>kdeui/tests/kcharselecttest.cpp <span style="color:grey">(b519c542149d2244977d0478a0e2f0edd1edd9b0)</span></li>
<li>kdeui/tests/kcodecactiontest.cpp <span style="color:grey">(6d7004340ffbeef24659a7d654baf13c996ba3d8)</span></li>
<li>kdeui/tests/kcolorcollectiontest.cpp <span style="color:grey">(8262213c94c9318955fc90b4ac4fc69b709cce99)</span></li>
<li>kdeui/tests/kcolordlgtest.cpp <span style="color:grey">(28d52c558a2161209d8fbed70d3bd78d81659bbf)</span></li>
<li>kdeui/tests/kcolorutilsdemo.cpp <span style="color:grey">(a6bb914b81f7f9b529164bc8faa133580c3c51e4)</span></li>
<li>kdeui/tests/kcomboboxtest.cpp <span style="color:grey">(ec453987cd204bc65924ad5bd2c8e58a5ecec390)</span></li>
<li>kdeui/tests/kcompletionuitest.cpp <span style="color:grey">(6ab5444294cfab76b52bbfc4dd53c7e01f7296cf)</span></li>
<li>kdeui/tests/kdatepicktest.cpp <span style="color:grey">(620ff7adc0fa815bcd8ca8fdfbc5d16ee964e63b)</span></li>
<li>kdeui/tests/kdatetabletest.cpp <span style="color:grey">(43e31d76e260e0a1e63118311874c7cb97f36deb)</span></li>
<li>kdeui/tests/kdatetimewidgettest.cpp <span style="color:grey">(39e05c0c6d514ba61c4dd4279a4fd3b31cb0638e)</span></li>
<li>kdeui/tests/kdatewidgettest.cpp <span style="color:grey">(2f8b568ffd336fcd5d6d714d606db0ee8db0bc5b)</span></li>
<li>kdeui/tests/keditlistboxtest.cpp <span style="color:grey">(d0713e06c7e292dbd88a551d5aa845c303502c39)</span></li>
<li>kdeui/tests/kfontdialogtest.cpp <span style="color:grey">(01cf2dae03ec0eb4b795b77ecf90a4915b649e0e)</span></li>
<li>kdeui/tests/kjobtrackerstest.cpp <span style="color:grey">(3168cb84199c5a2798ddefb967855e89ad2172f3)</span></li>
<li>kdeui/tests/kmainwindowrestoretest.cpp <span style="color:grey">(926613e003f0ac562126b6c3ab5f073ef3560768)</span></li>
<li>kdeui/tests/kmainwindowtest.cpp <span style="color:grey">(10b8db582ccdbf521084e3b35624ff6c728bfc3e)</span></li>
<li>kdeui/tests/kmanagerselectiontest.cpp <span style="color:grey">(e447ae267bdf328577fa767a2f18cf1b769a9039)</span></li>
<li>kdeui/tests/kmessagetest.cpp <span style="color:grey">(f6f1b869894d6fea7721a636d817b9dd33ad7b56)</span></li>
<li>kdeui/tests/kmodifierkeyinfotest.cpp <span style="color:grey">(1a5beeba45d4166497c85ab17ad2d6b90b89593d)</span></li>
<li>kdeui/tests/knewpassworddialogtest.cpp <span style="color:grey">(1ecb81a7d6a2da150cb1cc811c930679c73c5dfe)</span></li>
<li>kdeui/tests/knuminputtest.cpp <span style="color:grey">(a8c6a2c6c226dabb8c726685419f5cc4b962b734)</span></li>
<li>kdeui/tests/kpagedialogtest.cpp <span style="color:grey">(65f90f9586eead6fd626230522d53fed7def4b4d)</span></li>
<li>kdeui/tests/kpagewidgettest.cpp <span style="color:grey">(d8c4983eb4c2b1309770601c2a8d2a2334afc888)</span></li>
<li>kdeui/tests/kpassivepopuptest.cpp <span style="color:grey">(b0192251a4dd2f121d9c1a37a30da6db4c099742)</span></li>
<li>kdeui/tests/kpassworddialogtest.cpp <span style="color:grey">(11862b04475a9398d24df47489e8d210453c74ba)</span></li>
<li>kdeui/tests/kpixmapsequenceoverlaypaintertest.cpp <span style="color:grey">(04d2b3358d1262a4275e8264bd3555ce670b66d9)</span></li>
<li>kdeui/tests/kpopuptest.cpp <span style="color:grey">(a85f1bc387acda46a5ac4570a7c942b485a08523)</span></li>
<li>kdeui/tests/kprogressdialogtest.cpp <span style="color:grey">(8be3beff144c44e3774f6dbdc7412122071e30d7)</span></li>
<li>kdeui/tests/kreplacetest.cpp <span style="color:grey">(294a0cf46c4931d931a5dab68b5e2c7717060312)</span></li>
<li>kdeui/tests/krichtexteditor/main.cpp <span style="color:grey">(92fa2577eb31f2f99377c8bf7f427a857b98d11c)</span></li>
<li>kdeui/tests/krulertest.cpp <span style="color:grey">(9a22b0f3926af85329c6aaac6db19c85d13a593a)</span></li>
<li>kdeui/tests/kselectactiontest.cpp <span style="color:grey">(d72abe51e6a9232eb5dcc13fa3094ea7f184f071)</span></li>
<li>kdeui/tests/ksqueezedtextlabeltest.cpp <span style="color:grey">(2f25aaab6c00f71dec6a68a4f3488ebc9526061f)</span></li>
<li>kdeui/tests/kstatusbartest.cpp <span style="color:grey">(59e9ef10a49b1f215e26aa6ba3baf128ff2e87e3)</span></li>
<li>kdeui/tests/ksystemtraytest.cpp <span style="color:grey">(5248bdc0532837f1f0c6a131d93bd8f336260796)</span></li>
<li>kdeui/tests/ktabwidgettest.cpp <span style="color:grey">(477ac7b6a71f501a8518c632f0d5c6d48256f716)</span></li>
<li>kdeui/tests/ktextbrowsertest.cpp <span style="color:grey">(4d15ea2affa6194cfbf30151999aa9cac6a04efe)</span></li>
<li>kdeui/tests/ktextedittest.cpp <span style="color:grey">(d605bfc46584828aa1391d68c58bc80a58428ac8)</span></li>
<li>kdeui/tests/ktitlewidgettest.cpp <span style="color:grey">(c22d68f7ad4d53dbca745850d12c14825ebacacf)</span></li>
<li>kdeui/tests/ktoolbarlabelactiontest.cpp <span style="color:grey">(fa6e7ba31b6af2a3639ba77665171388e7c2653f)</span></li>
<li>kdeui/tests/ktoolbartest.cpp <span style="color:grey">(b1159dea61c2e9c88182c912d829bb4090bc5660)</span></li>
<li>kdeui/tests/ktreewidgetsearchlinetest.cpp <span style="color:grey">(e2047c3446858d2d8629cb0f3fb6083cce0a5c15)</span></li>
<li>kdeui/tests/kwidgetitemdelegatetest.cpp <span style="color:grey">(03ec36adb47e1b386806a1b3ccb43ac210167daf)</span></li>
<li>kdeui/tests/kwindowtest.cpp <span style="color:grey">(e435b0ca66a631bcb9dc8dd3c085aea0d82846ac)</span></li>
<li>kdeui/tests/kxmlguitest.cpp <span style="color:grey">(6bd9c8973d34a8491e587d1521dba9655584a7db)</span></li>
<li>kdeui/tests/kxmlguiwindowtest.cpp <span style="color:grey">(8f0162b525f0fe028034d6aeb5367cf511d3e653)</span></li>
<li>kfile/tests/kfiletreeviewtest.cpp <span style="color:grey">(137a373b46fd0d1421c7c491675cf3cc3a28faaf)</span></li>
<li>khtml/test_regression_gui_main.cpp <span style="color:grey">(c97854fbd601d4af8f74cc05c277608b6adf914b)</span></li>
<li>khtml/xpath/interpreter_tester.cpp <span style="color:grey">(88da20b484b40279d266a6455e416b58f6f7c410)</span></li>
<li>kio/tests/getalltest.cpp <span style="color:grey">(35233e238beb3506b17e7ae69623412192c40989)</span></li>
<li>kio/tests/kacltest.cpp <span style="color:grey">(91293c972b75a1ea29be7de22fead0cb614d56ed)</span></li>
<li>kio/tests/kdbusservicestartertest.cpp <span style="color:grey">(4bdfb3d8aa6769068bf4ee7fab1b4ca664ebbe22)</span></li>
<li>kio/tests/kdirlistertest_gui.cpp <span style="color:grey">(416ff31f6c18d56cf9f122f738c449a0591a7a97)</span></li>
<li>kio/tests/kfiledialogtest.cpp <span style="color:grey">(8e1f521f79cc863ba617765d46cca2aca0774983)</span></li>
<li>kio/tests/kiopassdlgtest.cpp <span style="color:grey">(cf0b48cedc824b041ff583150adb103534b2072f)</span></li>
<li>kio/tests/kopenwithtest.cpp <span style="color:grey">(b6c2a5e17ac247f0c4cd40c5d4a2bb6110adda6a)</span></li>
<li>kio/tests/kruntest.cpp <span style="color:grey">(14482555abab2e12cf3af8a88a61518c1e8f9a99)</span></li>
<li>kio/tests/kscantest.cpp <span style="color:grey">(88d8f56092c1b274657ed55cbeb532428057776b)</span></li>
<li>kio/tests/ksycocatest.cpp <span style="color:grey">(cecb8aaf1836914e39bb00fc94b2e88c5f6333e3)</span></li>
<li>kio/tests/ksycocaupdatetest.cpp <span style="color:grey">(ff82f87a5b5b4415630e81a45986e237637d528b)</span></li>
<li>kio/tests/netaccesstest.cpp <span style="color:grey">(a3e6b086185217e887c85a2f3a825e59341147b9)</span></li>
<li>kioslave/metainfo/metainfo.cpp <span style="color:grey">(793b84dd9f065d11b487a255be8a703a1d380a5d)</span></li>
<li>knewstuff/tests/kdxspreview.cpp <span style="color:grey">(26cda4eeba4ad73f4a0d896cc61653002065b05e)</span></li>
<li>knewstuff/tests/knewstuff2_cache.cpp <span style="color:grey">(e8b2d87452557a2ab304dcac77fd042934d0cc91)</span></li>
<li>knewstuff/tests/knewstuff2_download.cpp <span style="color:grey">(974704a9bc55a2b61c306875316e0b7fe02c69f7)</span></li>
<li>knotify/tests/main.cpp <span style="color:grey">(b22f0574a8c11c1c0a16fcce20baa77ec33af4c4)</span></li>
<li>kparts/tests/normalktm.cpp <span style="color:grey">(997601b67237386db9ecceac385de7efc5f2bb2a)</span></li>
<li>kparts/tests/openorsavequestion.cpp <span style="color:grey">(f534dfacc9d1fc33511cbed7a25bc7a33be6861a)</span></li>
<li>kparts/tests/testmainwindow.cpp <span style="color:grey">(8468ce84d5fb5768857d675db50d1ab4a747ee00)</span></li>
<li>kutils/kemoticons/tests/main.cpp <span style="color:grey">(5f0933a545d2699604b4be672a317ade57cfd5f2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105897/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div></div>
</div>
</blockquote></div><br>