[kdelibs/frameworks] /: Split out a kcodecs framework.
faure at kde.org
Sun Apr 29 13:36:41 UTC 2012
On Sunday 29 April 2012 15:18:45 Stephen Kelly wrote:
> David Faure wrote:
> > On Sunday 29 April 2012 14:16:06 Stephen Kelly wrote:
> >> Git commit d40f8ea2375ff6133d225b787f480091ca62a21b by Stephen Kelly.
> >> Committed on 29/04/2012 at 14:14.
> >> Pushed by skelly into branch 'frameworks'.
> > These things (macro expansion, string handler methods, etc.) have nothing
> > to do with "codecs". So I'm not sure the framework is named appropriately,
> > or that kstringhandler belongs to it.
> > kstringhandler is "addon features for QString", so I thought it was
> > fitting pretty well in kcoreaddons.
> > Alternatively, the framework could be called something more generic, but
> > since kconfig uses kstringhandler::obscure+from8Bit, most of the code in
> > tier2 and above will end up depending on that framework...
> > I think it would be better to move kstringhandler back to kcoreaddons.
> > KStringHandler doesn't depend on any of the kcodecs stuff.
> Ok, so how about I move KMacroExpander and KStringHandler back to
> kcoreaddons? Is there anything else I should do?
Thanks, sounds good.
PS: you forgot a file I think:
The source directory
does not contain a CMakeLists.txt file.
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
More information about the Kde-frameworks-devel