[kdelibs/frameworks] /: Split out a kcodecs framework.

[David Faure]

On Sunday 29 April 2012 14:16:06 Stephen Kelly wrote:
> Git commit d40f8ea2375ff6133d225b787f480091ca62a21b by Stephen Kelly.
> Committed on 29/04/2012 at 14:14.
> Pushed by skelly into branch 'frameworks'.
> 
> Split out a kcodecs framework.
> 
> This makes kcoreaddons much smaller. These classes are rarely used
> even in kdelibs. I'm not actually sure what the kde codes system
> offers over and above the Qt one...

probers/ is about auto-detection [of the codec, based on an input string].
Qt doesn't offer that at all.

> tier1/kcoreaddons/src/text/kencodingprober.h - 097% similarity] R  +0    -0
>    tier1/kcodecs/src/kentities.c [from:
> tier1/kcoreaddons/src/text/kentities.c - 100% similarity] R  +0    -0   
> tier1/kcodecs/src/kmacroexpander.cpp [from:
> tier1/kcoreaddons/src/text/kmacroexpander.cpp - 100% similarity] R  +12  
> -12   tier1/kcodecs/src/kmacroexpander.h [from:
> tier1/kcoreaddons/src/text/kmacroexpander.h - 093% similarity] R  +0    -0 
>   tier1/kcodecs/src/kmacroexpander_p.h [from:
> tier1/kcoreaddons/src/text/kmacroexpander_p.h - 100% similarity] R  +0   
> -0    tier1/kcodecs/src/kmacroexpander_unix.cpp [from:
> tier1/kcoreaddons/src/text/kmacroexpander_unix.cpp - 100% similarity] R  +0
>    -0    tier1/kcodecs/src/kmacroexpander_win.cpp [from:
> tier1/kcoreaddons/src/text/kmacroexpander_win.cpp - 100% similarity] R  +0 
>   -0    tier1/kcodecs/src/kstringhandler.cpp [from:
> tier1/kcoreaddons/src/text/kstringhandler.cpp - 100% similarity] R  +15  
> -15   tier1/kcodecs/src/kstringhandler.h [from:

These things (macro expansion, string handler methods, etc.) have nothing to 
do with "codecs". So I'm not sure the framework is named appropriately, or 
that kstringhandler belongs to it.
kstringhandler is "addon features for QString", so I thought it was fitting 
pretty well in kcoreaddons.
Alternatively, the framework could be called something more generic, but since 
kconfig uses kstringhandler::obscure+from8Bit, most of the code in tier2 and 
above will end up depending on that framework...
I think it would be better to move kstringhandler back to kcoreaddons.
KStringHandler doesn't depend on any of the kcodecs stuff.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5