use of QFileDialog
Aaron J. Seigo
aseigo at kde.org
Sat Nov 5 10:46:51 UTC 2011
hi :)
since QFileDialog now uses the platform dialog, including the KDE one, what do
people think about replacing more direct usages of KFileDialog with
QFileDialog? or is that already planned?
i just looked at KIconButton and KIconDialog today which are in kio/kfile/ and
it was interesting that the only reason those classes are in kfile is because
they use KFileDialog and KImageFilePreview directly.
the usage of KImageFilePreview there is unecessary these days as the file
dialog does very nice in-dialog previews and the user can turn the full
preview on themselves quite easily. in fact, it's probably nicer to respect
the user's settings for the file dialog than manually overriding things on
them.
which just leaves KIconDialog/Button with KFileDialog usage. other than the
preview widget, it seems its usage of the file dialog could easily be replaced
with QFileDialog, and then KIconDialog/Button (after being split into two
files as they should have been long ago :) could be moved into the appropriate
split-from-kdeui library.
thoughts? if that sounds ok to people, i'll do this today ...
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20111105/18e31396/attachment.sig>
More information about the Kde-frameworks-devel
mailing list