GSoC 21 KMyMoney: Replacing member functions of WebPriceQuote

[Thomas Baumgart]

On Sonntag, 4. Juli 2021 21:54:54 CEST Suraj Kumar Mahto wrote:

> Hello,
> While replacing the classes like WebPriceQuoteSources with
> AlkOnlineQuoteSources and other such cases, I saw that the member(like
> identifyBy) is not implemented in alkimia. Does that mean I have to add
> those members and functions in libalkimia repo similarly to that done in
> webpricequote?

I would suggest to add two more members to AlkOnlineQuoteSource::Private:

a) m_idNumber (QString)
b) m_idSelector (enum)

The default should be empty and the selector should point to symbol to
maintain backward compatibility. Add getters and setters and update
read() and write() to store them with the quote source. You may also
have to adjust the locations where sym() is used today in
AlkOnlineQuote::Private.

> I have tried to implement AlkOnlineQuote::setDate() (similar to that of
> webpricequote) in alkimia repo earlier but getting some reference error. I
> skipped that thinking that will check that part once I replace all the
> WebPriceQuote implementation in that file (kequitypriceupdatedlg.cpp) .

m_fromDate and m_toDate in WebPriceQuote are only used in connection with
CSV downloads and I think we skipped those completely for the moment, as
they are not supported by Alkimia. So don't worry about them for the moment.


-- 

Regards

Thomas Baumgart

https://www.signal.org/       Signal, the better WhatsApp
-------------------------------------------------------------
Computers let you make more mistakes faster than any other
invention in human history, with the possible exception
of handguns and tequila. --Mitch Radcliffe
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20210705/13b1d915/attachment.sig>