Question about SQLite database's valid_upto field

[Prasun Kumar]

Thanks for the review, sir. I will incorporate your suggestions in my
coding style.

Can you explain this one:

> 3. end...() tags should always be empty
>

And, is this one necessary?:

> 4. use 4 spaces, no tabs
>

Is there any specific reason for this in this project? I have always use
tabs and I know there are different views on this matter,
but I could use spaces if it is required for this project.

Thanks.
Prasun

On Wed, 10 Jun 2020 at 17:33, Ralf Habacker <ralf.habacker at freenet.de>
wrote:

> Am 08.06.20 um 20:01 schrieb Prasun Kumar:
> Hi Prasun,
>
> > BTW did you have a look at the commits I made?
> yes
> > I have made some changes to the CMake build system and frankly I have
> not had much previous
> > experience with CMake.
>
> This is learning by doing and examining the work from others.
>
> Here are some generic rules :
>
> 1. function names should be lower_case  e.g.
>
>    function(extract_date ARG)
>
> and usage too
>
>     extract_date(VALID_DATE)
>
> 2. no space between if and (
>
> 3. end...() tags should always be empty
>
> 4. use 4 spaces, no tabs
>
>
> It may help from time to time to use a script I wrote some time ago, see
> https://gitlab.freedesktop.org/dbus/dbus/-/blob/master/tools/cmake-format
>
> If you use qtcreator as IDE, you can reduce the time for searching by
> installing the cmake qthelp file (see https://cmake.org/documentation/)
> to get context help by pressing F1 on a cmake command
>
>  From https://doc.qt.io/qtcreator/creator-help.html
> "To select and configure how the documentation is displayed in the Help
> mode, select Tools > Options > Help."
>
> > Can you verify that I have not added anything
> > that could cause problems in the future?
>
> You are in a private feature branch that needs to be summarized a little
> at a time when a particular topic is being completed. Examples of this
> are commits with "fixes" and "removed" which should then be incorporated
> into the underlying commits.
>
> What I also see is that the branch contains commits with minor changes
> that make it easier to merge later.
>
> I can also see that there is a new make target name 'bankdata_db' which
> creates a sqlite database on call and the created database can be used
> with the sqlite3 command.
>
> I do not see any problems at the moment - looks good.
>
> Regards
> Ralf
>
> >
> > On Mon, 8 Jun 2020, 12:58 Ralf Habacker, <ralf.habacker at freenet.de
> > <mailto:ralf.habacker at freenet.de>> wrote:
> >
> >     Am 02.06.20 um 17:58 schrieb Prasun Kumar:
> >
> >      > Currently, KtoBlzCheck downloads a bank sort file at compilation
> and
> >      > uses it to generate a bankdata text file. This file is then used
> to
> >      > service the library
> >      > and afaik there is no way to update datafile without recompiling.
> >     It is usual behavior to perform  things beside compiling with the
> build
> >     system by using specific make targets. cmake provides a target to
> show
> >     all defined targets:
> >
> >     ~/src/ktoblzcheck-build> make help
> >     The following are some of the valid targets for this Makefile:
> >     ... all (the default if no target is provided)
> >     ... clean
> >     ... depend
> >     ... edit_cache
> >     ... install
> >     ... install/local
> >     ... install/strip
> >     ... list_install_components
> >     ... package
> >     ... package_source
> >     ... rebuild_cache
> >     ... test
> >     ... apidoc
> >     ... bankdata_de
> >     ... dist
> >     ... doc
> >     ... fetch_bankdata
> >     ... fetch_sepa
> >     ... rpm
> >     ... srpm
> >     ... uncrustify
> >     ... benchmark
> >     ... ctest
> >     ... date_test
> >     ... iban_check
> >     ... ibanchk
> >     ... ktoblzcheck
> >     ... ktoblzcheck-bin
> >
> >     To perform the target to download the raw bankdata file and convert
> it
> >     simply run:
> >
> >     ~/src/ktoblzcheck-build> make bankdata_de
> >     [ 50%] Download raw bank data file to
> >     /home/ralf.habacker/src/ktoblzcheck/src/bankdata/blz_20200608.txt
> >     got file url
> >
> https://www.bundesbank.de//resource/blob/602632/31fec41357f012d537ce62045395929a/mL/blz-aktuell-txt-data.txt
> >     [100%] Generating
> >     /home/xxx/src/ktoblzcheck/src/bankdata/bankdata_20200608.txt
> >     Read data from
> >     "/home/xxx/src/ktoblzcheck/src/bankdata/blz_20200608.txt"
> >     with "iso 8859-1" encoding
> >     Added 3536 institutions to output
> >     file"/home/xxx/src/ktoblzcheck/src/bankdata/bankdata_20200608.txt"
> >     [100%] Built target bankdata_de
> >
> >     Regards
> >     Ralf
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20200611/0a107abc/attachment-0001.htm>