<div dir="ltr"><div>Thanks for the review, sir. I will incorporate your suggestions in my coding style.</div><div><br></div><div>Can you explain this one:</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>3. end...() tags should always be empty </div></blockquote><div><br></div><div>And, is this one necessary?:</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>4. use 4 spaces, no tabs</div></blockquote><div><br></div><div>Is there any specific reason for this in this project? I have always use tabs and I know there are different views on this matter, </div><div>but I could use spaces if it is required for this project.</div><div><br></div><div>Thanks.</div><div>Prasun<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 10 Jun 2020 at 17:33, Ralf Habacker <<a href="mailto:ralf.habacker@freenet.de">ralf.habacker@freenet.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am 08.06.20 um 20:01 schrieb Prasun Kumar:<br>
Hi Prasun,<br>
<br>
> BTW did you have a look at the commits I made? <br>
yes<br>
> I have made some changes to the CMake build system and frankly I have not had much previous <br>
> experience with CMake. <br>
<br>
This is learning by doing and examining the work from others.<br>
<br>
Here are some generic rules :<br>
<br>
1. function names should be lower_case e.g.<br>
<br>
function(extract_date ARG)<br>
<br>
and usage too<br>
<br>
extract_date(VALID_DATE)<br>
<br>
2. no space between if and (<br>
<br>
3. end...() tags should always be empty<br>
<br>
4. use 4 spaces, no tabs<br>
<br>
<br>
It may help from time to time to use a script I wrote some time ago, see <br>
<a href="https://gitlab.freedesktop.org/dbus/dbus/-/blob/master/tools/cmake-format" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/dbus/dbus/-/blob/master/tools/cmake-format</a><br>
<br>
If you use qtcreator as IDE, you can reduce the time for searching by <br>
installing the cmake qthelp file (see <a href="https://cmake.org/documentation/" rel="noreferrer" target="_blank">https://cmake.org/documentation/</a>) <br>
to get context help by pressing F1 on a cmake command<br>
<br>
From <a href="https://doc.qt.io/qtcreator/creator-help.html" rel="noreferrer" target="_blank">https://doc.qt.io/qtcreator/creator-help.html</a><br>
"To select and configure how the documentation is displayed in the Help <br>
mode, select Tools > Options > Help."<br>
<br>
> Can you verify that I have not added anything <br>
> that could cause problems in the future?<br>
<br>
You are in a private feature branch that needs to be summarized a little <br>
at a time when a particular topic is being completed. Examples of this <br>
are commits with "fixes" and "removed" which should then be incorporated <br>
into the underlying commits.<br>
<br>
What I also see is that the branch contains commits with minor changes <br>
that make it easier to merge later.<br>
<br>
I can also see that there is a new make target name 'bankdata_db' which <br>
creates a sqlite database on call and the created database can be used <br>
with the sqlite3 command.<br>
<br>
I do not see any problems at the moment - looks good.<br>
<br>
Regards<br>
Ralf<br>
<br>
> <br>
> On Mon, 8 Jun 2020, 12:58 Ralf Habacker, <<a href="mailto:ralf.habacker@freenet.de" target="_blank">ralf.habacker@freenet.de</a> <br>
> <mailto:<a href="mailto:ralf.habacker@freenet.de" target="_blank">ralf.habacker@freenet.de</a>>> wrote:<br>
> <br>
> Am 02.06.20 um 17:58 schrieb Prasun Kumar:<br>
> <br>
> > Currently, KtoBlzCheck downloads a bank sort file at compilation and<br>
> > uses it to generate a bankdata text file. This file is then used to<br>
> > service the library<br>
> > and afaik there is no way to update datafile without recompiling.<br>
> It is usual behavior to perform things beside compiling with the build<br>
> system by using specific make targets. cmake provides a target to show<br>
> all defined targets:<br>
> <br>
> ~/src/ktoblzcheck-build> make help<br>
> The following are some of the valid targets for this Makefile:<br>
> ... all (the default if no target is provided)<br>
> ... clean<br>
> ... depend<br>
> ... edit_cache<br>
> ... install<br>
> ... install/local<br>
> ... install/strip<br>
> ... list_install_components<br>
> ... package<br>
> ... package_source<br>
> ... rebuild_cache<br>
> ... test<br>
> ... apidoc<br>
> ... bankdata_de<br>
> ... dist<br>
> ... doc<br>
> ... fetch_bankdata<br>
> ... fetch_sepa<br>
> ... rpm<br>
> ... srpm<br>
> ... uncrustify<br>
> ... benchmark<br>
> ... ctest<br>
> ... date_test<br>
> ... iban_check<br>
> ... ibanchk<br>
> ... ktoblzcheck<br>
> ... ktoblzcheck-bin<br>
> <br>
> To perform the target to download the raw bankdata file and convert it<br>
> simply run:<br>
> <br>
> ~/src/ktoblzcheck-build> make bankdata_de<br>
> [ 50%] Download raw bank data file to<br>
> /home/ralf.habacker/src/ktoblzcheck/src/bankdata/blz_20200608.txt<br>
> got file url<br>
> <a href="https://www.bundesbank.de//resource/blob/602632/31fec41357f012d537ce62045395929a/mL/blz-aktuell-txt-data.txt" rel="noreferrer" target="_blank">https://www.bundesbank.de//resource/blob/602632/31fec41357f012d537ce62045395929a/mL/blz-aktuell-txt-data.txt</a><br>
> [100%] Generating<br>
> /home/xxx/src/ktoblzcheck/src/bankdata/bankdata_20200608.txt<br>
> Read data from<br>
> "/home/xxx/src/ktoblzcheck/src/bankdata/blz_20200608.txt"<br>
> with "iso 8859-1" encoding<br>
> Added 3536 institutions to output<br>
> file"/home/xxx/src/ktoblzcheck/src/bankdata/bankdata_20200608.txt"<br>
> [100%] Built target bankdata_de<br>
> <br>
> Regards<br>
> Ralf<br>
> <br>
</blockquote></div>