Phase 2 commits

[Ralf Habacker]

Am 08.08.20 um 05:28 schrieb Prasun Kumar:
Hi Prasun,

> The rest of the work from the second phase has been completed. The databases
> for the additional countries have been incorporated in the library. 
> Please take a look and suggest any necessary changes.

I took a look

> Commits: 
> https://sourceforge.net/u/prasun/ktoblzcheck-gsoc2020/commit_browser
> Blog post: https://prasunka.github.io/posts/gsoc2020-phase-2

ktoblzcheck help screen shows these error conditions

	1: Validation algorithm is unknown/unimplemented
         2: Account and bank do not match
         3: No bank with given bank-id found

which are not checked by the currently present "invalid" test checks.

The present 'ktoblzcheck_invalid' checks only result (2) for german 
databases:

    7: Bank: 'Hamburger Sparkasse' at 'Hamburg 
  ' (20050550)
    7: Account: 1262693333
    7: Result is: (2) ERROR: account and bank do not match

which should be extended to cover all error conditions and languages.

e.g.
add_test(NAME ktoblzcheck_invalid1 ...)
add_test(NAME ktoblzcheck_invalid2 ...)
add_test(NAME ktoblzcheck_invalid3 ...)

add_test(NAME ktoblzcheck_nl_invalid1 ...)
add_test(NAME ktoblzcheck_nl_invalid2 ...)
add_test(NAME ktoblzcheck_nl_invalid3 ...)

add_test(NAME ktoblzcheck_ch_invalid1 ...)
add_test(NAME ktoblzcheck_ch_invalid2 ...)
add_test(NAME ktoblzcheck_ch_invalid3 ...)

The checks for german database could also be renamed to use the common 
test name style:

add_test(NAME ktoblzcheck_de_invalid1 ...)
add_test(NAME ktoblzcheck_de_invalid2 ...)
add_test(NAME ktoblzcheck_de_invalid3 ...)

to match the language.

ktoblzcheck is designed to use database files from default location

   $ ktoblzcheck --help
   Usage:
   ktoblzcheck [--returncode] [--file=datafile] <bank-id> <account-id>


but how to specify another language without using the --file parameter.

A possibility would be to add a <country-code> option  e.g.

ktoblzcheck [--returncode] [--file=datafile] [<country-code>] <bank-id> 
<account-id>

to run

ktoblzcheck de 20050550 1262693334

or

ktoblzcheck nl "ABNA" "0417164300"


PS: Good job so far

Regards
Ralf