[Kde-extra-gear] cvsExtract patch

Sebastian Trueg kde-extra-gear@mail.kde.org
Mon, 10 Feb 2003 20:06:39 +0100


On Monday 10 February 2003 17:13, Klas Kalass wrote:
> Am Montag, 10. Februar 2003 16:46 schrieb Sebastian Trueg:
> > On Monday 10 February 2003 15:52, Klas Kalass wrote:
> > > Am Montag, 10. Februar 2003 15:33 schrieb Sebastian Trueg:
> > > I have a small nitpick again, but will do this when you commited (I
> > > don't like side-effects, even in shell-scripts)
> >
> > what do you mean?
>
> I meant that your function is pre-destined to return the languages as a
> return value and not to modify the global variable, because it is called
> getAvailableLanguages and obviously its reason is not to retrieve anything
> to disk or such. But I know that in this context it is pretty weak.
>
> See the attached diff.

cool. :)