D27994: Improvement in Solar System Hints

[Johnny Jazeix]

jjazeix accepted this revision.
jjazeix added a comment.
This revision is now accepted and ready to land.


  Hi, under which name should I commit? "FirstName LastName <email>" for the syntax :)

INLINE COMMENTS

> SolarSystem.qml:394
> +                else{
> +                    if(items.hintProvided)
> +                        displayDialog(hintDialog)

it should not be needed as we should not display the hint icon if no hint is provided (meaning we can't click on it)

REVISION DETAIL
  https://phabricator.kde.org/D27994

To: anujyadav, #gcompris_improvements, jjazeix
Cc: jjazeix, timotheegiet, kde-edu, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, asagtani, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200327/bffccb79/attachment.html>