<table><tr><td style="">jjazeix accepted this revision.<br />jjazeix added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27994">View Revision</a></tr></table><br /><div><div><p>Hi, under which name should I commit? "FirstName LastName <email>" for the syntax :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27994#inline-161088">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SolarSystem.qml:394</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa4000">else</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span class="bright"></span><span style="color: #004012"><span class="bright">displayDialog</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #004012">hint<span class="bright">Dialog</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">else<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span style="color: #004012">hint<span class="bright">Provided</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #004012">displayDialog</span><span class="p">(</span><span style="color: #004012">hintDialog</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it should not be needed as we should not display the hint icon if no hint is provided (meaning we can't click on it)</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27994">https://phabricator.kde.org/D27994</a></div></div><br /><div><strong>To: </strong>anujyadav, GCompris: Improvements, jjazeix<br /><strong>Cc: </strong>jjazeix, timotheegiet, kde-edu, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, asagtani, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, bcoudoin<br /></div>